Review main Merged

62773[BUGFIX] Test failure due to erroneous usage of uniqueId() function

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 12/27/19, 20:23

Commit message

The function in testing-framework provides a string that is target to be
used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it
to produce a random userId, which needs to be an integer.
If the randomly produced string contains not only numbers, the cast
operation converts the uid to 0 and therefor prevents a DB query
from execution. This prevention results in a not consumed mock object,
which in turn causes a integration test failure.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 12/27/19, 14:43

  2. TYPO3com voted on patch set 1 V +1 12/27/19, 14:52 Completed build in 08m 20s on Fri, 27 Dec, 02:52 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39591

  3. Benni Mack commented on patch set 1 12/27/19, 15:05

    BackendUserAuthenticationTest.php:108

    why not just use a static number?
  4. Anja Leichsenring uploaded patch set 2 12/27/19, 15:08

  5. Anja Leichsenring commented on patch set 2 12/27/19, 15:09

    BackendUserAuthenticationTest.php:108 Reply Unresolved

    good question. Replaced.
  6. Anja Leichsenring updated the commit message in patch set 3 12/27/19, 15:15

  7. TYPO3com voted on patch set 2 V +1 12/27/19, 15:17 Completed build in 08m 52s on Fri, 27 Dec, 03:17 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39593

  8. TYPO3com voted on patch set 3 V +1 12/27/19, 15:26 Completed build in 10m 41s on Fri, 27 Dec, 03:26 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39595

  9. Benni Mack voted on patch set 3 V +2 CR +2 12/27/19, 15:28

  10. Benni Mack merged patch set 4 12/27/19, 15:28

  11. Oliver Hader voted on patch set 4 CR +1 12/27/19, 20:23