Review main Merged

62774[TASK] Replace usage of BaseTestCase::getUniqueId() with core function

Anja Leichsenring CR +2 V +2 Expert +685 −622 updated 12/30/19, 09:47

Commit message

Tests can use the core function StringUtility::getUniqueId(), after both
functions provide the same service.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 63

Show 43 more files

Review log 610

  1. Anja Leichsenring uploaded patch set 1 12/27/19, 15:35

  2. TYPO3com voted on patch set 1 V -1 12/27/19, 15:37 Completed build in 31s on Fri, 27 Dec, 03:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39598

  3. Anja Leichsenring uploaded patch set 2 12/27/19, 15:42

  4. TYPO3com voted on patch set 2 V +1 12/27/19, 15:51 Completed build in 08m 58s on Fri, 27 Dec, 03:51 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39599

  5. Anja Leichsenring updated the commit message in patch set 3 12/30/19, 08:33

  6. TYPO3com voted on patch set 3 V +1 12/30/19, 08:45 Completed build in 11m 10s on Mon, 30 Dec, 08:45 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39657

  7. Benni Mack updated the commit message in patch set 4 12/30/19, 09:26

  8. TYPO3com voted on patch set 4 V +1 12/30/19, 09:46 Completed build in 16m 32s on Mon, 30 Dec, 09:46 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39660

  9. Benni Mack voted on patch set 4 V +2 CR +2 12/30/19, 09:47

  10. Benni Mack merged patch set 5 12/30/19, 09:47