62775[TASK] Refactor & streamline TypoLinkViewHelper implementations
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+58 −58
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+45 −33
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TypolinkViewHelperTest.php+41 −0
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/TypolinkViewHelperTest.php+191 −147
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/TypolinkViewHelperTest.php+146 −65
Review log 1115
-
Oliver Hader uploaded patch set 1 12/27/19, 20:13
-
Oliver Hader updated the commit message in patch set 2 12/27/19, 20:14
-
Oliver Hader updated the commit message in patch set 3 12/27/19, 20:14
-
TYPO3com voted on patch set 1 V +1 12/27/19, 20:25 Completed build in 11m 14s on Fri, 27 Dec, 08:25 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39605
-
TYPO3com voted on patch set 2 V +1 12/27/19, 20:31 Completed build in 16m 58s on Fri, 27 Dec, 08:31 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39606
-
TYPO3com voted on patch set 3 V +1 12/27/19, 20:38 Completed build in 13m 36s on Fri, 27 Dec, 08:38 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39607
-
Oliver Hader updated the commit message in patch set 4 12/27/19, 20:43
-
TYPO3com voted on patch set 4 V +1 12/27/19, 20:52 Completed build in 09m 05s on Fri, 27 Dec, 08:52 PM Test Summary: 69082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39610
-
Benni Mack voted on patch set 4 V +1 CR +1 12/27/19, 21:01
-
Benni Mack voted on patch set 4 V 0 CR 0 12/27/19, 21:01
-
Oliver Hader voted on patch set 4 CR +1 12/27/19, 21:02
-
Oliver Hader commented on patch set 4 CR 0 12/27/19, 21:02
(sorry, wrong patch) -
Benni Mack voted on patch set 4 V +1 CR +1 12/27/19, 21:36
-
Georg Ringer voted on patch set 4 V +2 CR +2 01/08/20, 08:40
-
Georg Ringer merged patch set 5 01/08/20, 08:40