Review main Merged

62775[TASK] Refactor & streamline TypoLinkViewHelper implementations

Oliver Hader CR +2 V +2 Hard +481 −303 updated 01/08/20, 08:40

Commit message

* avoid assigning and forwarding multiple variables
* preparation for further enhancements of view helpers
* Uri UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest) and to 1/3 a simple additionalParams case
* Link UnitTest case mostly tested TypoLinkCodecService
  (it was a FunctionalTest)

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1115

  1. Oliver Hader uploaded patch set 1 12/27/19, 20:13

  2. Oliver Hader updated the commit message in patch set 2 12/27/19, 20:14

  3. Oliver Hader updated the commit message in patch set 3 12/27/19, 20:14

  4. TYPO3com voted on patch set 1 V +1 12/27/19, 20:25 Completed build in 11m 14s on Fri, 27 Dec, 08:25 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39605

  5. TYPO3com voted on patch set 2 V +1 12/27/19, 20:31 Completed build in 16m 58s on Fri, 27 Dec, 08:31 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39606

  6. TYPO3com voted on patch set 3 V +1 12/27/19, 20:38 Completed build in 13m 36s on Fri, 27 Dec, 08:38 PM Test Summary: 69083 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39607

  7. Oliver Hader updated the commit message in patch set 4 12/27/19, 20:43

  8. TYPO3com voted on patch set 4 V +1 12/27/19, 20:52 Completed build in 09m 05s on Fri, 27 Dec, 08:52 PM Test Summary: 69082 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39610

  9. Benni Mack voted on patch set 4 V +1 CR +1 12/27/19, 21:01

  10. Benni Mack voted on patch set 4 V 0 CR 0 12/27/19, 21:01

  11. Oliver Hader voted on patch set 4 CR +1 12/27/19, 21:02

  12. Oliver Hader commented on patch set 4 CR 0 12/27/19, 21:02

    (sorry, wrong patch)
  13. Benni Mack voted on patch set 4 V +1 CR +1 12/27/19, 21:36

  14. Georg Ringer voted on patch set 4 V +2 CR +2 01/08/20, 08:40

  15. Georg Ringer merged patch set 5 01/08/20, 08:40