Review main Merged

62778[BUGFIX] Do not reference EventDispatcher in TYPO3 Core

Benni Mack CR +2 V +2 Easy +15 −18 updated 01/10/20, 14:04

Commit message

With Dependency Injection, the new PSR-14 based
EventDispatcher, built into TYPO3 Core should never
be exposed to our core code, since we should always
reference the EventDispatcherInterface. We do this
in almost all cases, except for a few places where
we introduced PSR-14 before DI.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1623

  1. Benni Mack uploaded patch set 1 12/28/19, 22:36

  2. TYPO3com voted on patch set 1 V +1 12/28/19, 22:45 Completed build in 08m 33s on Sat, 28 Dec, 10:45 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39642

  3. Benni Mack updated the commit message in patch set 2 12/30/19, 07:29

  4. Benni Mack updated the commit message in patch set 3 12/30/19, 07:29

  5. Benni Mack updated the commit message in patch set 4 12/30/19, 07:30

  6. TYPO3com voted on patch set 3 V +1 12/30/19, 07:50 Completed build in 20m 03s on Mon, 30 Dec, 07:50 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39652

  7. TYPO3com voted on patch set 4 V +1 12/30/19, 07:54 Completed build in 23m 34s on Mon, 30 Dec, 07:54 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39653

  8. TYPO3com voted on patch set 2 V -1 12/30/19, 07:56 Completed build in 26m 06s on Mon, 30 Dec, 07:56 AM Test Summary: 69118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39651

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 12/30/19, 09:29

  10. Oliver Hader voted on patch set 4 CR +1 12/31/19, 12:22

  11. Oliver Hader commented on patch set 4 V -1 12/31/19, 12:34

    EventDispatcherInterface does not seem to be injected. @Anja: Seems like you tested it successfully, could you please let me know how to do it?
  12. Benni Mack uploaded patch set 5 01/08/20, 08:28

  13. Benni Mack commented on patch set 5 01/08/20, 08:30

    @Olly: Did not work before, as the Mailer was not configured in the Services.yaml. I did test this with the email notification when logging in the TYPO3 Backend.
  14. TYPO3com voted on patch set 5 V -1 01/08/20, 08:37 Completed build in 08m 46s on Wed, 8 Jan, 08:37 AM Test Summary: 1 of 69411 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39753

  15. TYPO3com voted on patch set 5 V +1 01/08/20, 08:44 Completed build in 24m 57s on Wed, 8 Jan, 08:44 AM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39753

  16. Oliver Klee commented on patch set 5 01/08/20, 10:54

    Mailer.php:69 Unresolved

    We either need to add the @param annotation for this as well or remove the other @param annotation. And should it be nullable?
  17. Benni Mack uploaded patch set 6 01/08/20, 11:08

  18. Benni Mack commented on patch set 5 01/08/20, 11:08

    Thanks, Oli!
  19. TYPO3com voted on patch set 6 V +1 01/08/20, 11:17 Completed build in 09m 14s on Wed, 8 Jan, 11:17 AM Test Summary: 69197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39755

  20. Georg Ringer voted on patch set 6 V +1 CR +1 01/08/20, 13:32

  21. Anja Leichsenring voted on patch set 6 V +1 CR +1 01/10/20, 11:08

  22. Benni Mack voted on patch set 6 V +2 CR +2 01/10/20, 14:04

  23. Benni Mack merged patch set 7 01/10/20, 14:04