Review main Merged

62780[BUGFIX] Return integer value from Command::execute()

Michael Schams CR +2 V +2 Easy +2 −0 updated 12/31/19, 13:05

Commit message

Symfony version 5 expects an integer as the return value from
Command::execute() in the Command class. This bugfix returns 0 to
satisfy Symfony version 5 requirements.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Michael Schams uploaded patch set 1 12/29/19, 05:33

  2. TYPO3com voted on patch set 1 V -1 12/29/19, 05:47 Completed build in 13m 32s on Sun, 29 Dec, 05:47 AM Test Summary: 5 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39645

  3. TYPO3com voted on patch set 1 V +1 12/30/19, 11:34 Completed build in 6h 14m 13s on Mon, 30 Dec, 11:34 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39645

  4. Oliver Klee voted on patch set 1 CR +1 12/30/19, 14:18

  5. Benni Mack voted on patch set 1 V +2 CR +1 12/30/19, 21:28

  6. Oliver Hader voted on patch set 1 V +2 CR +2 12/31/19, 13:05

  7. Oliver Hader merged patch set 2 12/31/19, 13:05