Review main Merged

62781[BUGFIX] Replace regexp capture groups for redirects

Guido Schmechel CR +2 V +2 Normal +61 −9 updated 01/14/20, 20:46

Commit message

The capture group in the redirect target are now replaced,
so redirects with regular expressions are working
referencing the original URL.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Guido Schmechel uploaded patch set 1 12/29/19, 11:51

  2. TYPO3com voted on patch set 1 V -1 12/29/19, 11:51 Completed build in 12s on Sun, 29 Dec, 11:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39646

  3. Guido Schmechel uploaded patch set 2 12/29/19, 11:53

  4. TYPO3com voted on patch set 2 V +1 12/29/19, 12:00 Completed build in 07m 21s on Sun, 29 Dec, 12:00 PM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39647

  5. Guido Schmechel updated the commit message in patch set 3 12/29/19, 12:03

  6. TYPO3com voted on patch set 3 V +1 12/29/19, 12:10 Completed build in 06m 54s on Sun, 29 Dec, 12:10 PM Test Summary: 69133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39648

  7. Oliver Klee commented on patch set 3 12/29/19, 16:58

    Can we have something in the commit message title (or description) that explains what the problem was?
  8. Benni Mack updated the commit message in patch set 4 12/30/19, 07:58

  9. Benni Mack voted on patch set 4 V +1 CR +1 12/30/19, 07:58

  10. TYPO3com voted on patch set 4 V +1 12/30/19, 08:06 Completed build in 07m 53s on Mon, 30 Dec, 08:06 AM Test Summary: 69133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39655

  11. Susi Moog voted on patch set 4 V +2 CR +2 01/14/20, 20:46

  12. Susi Moog merged patch set 5 01/14/20, 20:46