62783[TASK] Further clean ups in extension manager code
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Jörg Bösche +1
- Steffen Frese +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php1+17 −1
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+4 −1
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+10 −5
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php2+16 −36
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+5 −29
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/EmConfUtilityTest.php+15 −6
Review log 915
-
Benni Mack uploaded patch set 1 12/30/19, 07:27
-
TYPO3com voted on patch set 1 V -1 12/30/19, 07:53 Completed build in 25m 30s on Mon, 30 Dec, 07:53 AM Test Summary: 12 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39650
-
Benni Mack uploaded patch set 2 12/30/19, 08:33
-
TYPO3com voted on patch set 2 V -1 12/30/19, 08:42 Completed build in 09m 11s on Mon, 30 Dec, 08:42 AM Test Summary: 1 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39656
-
TYPO3com voted on patch set 2 V +1 12/30/19, 09:17 Completed build in 53m 38s on Mon, 30 Dec, 09:17 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39656
-
Oliver Klee commented on patch set 2 12/30/19, 14:21
FileHandlingUtility.php:323UnresolvedWhile we're changing the signature here anyway, can we have a return type as well? (Ditto for the other signature changes in this file.)FileHandlingUtility.php:349UnresolvedShould we have a string cast here (just to be safe)? -
Benni Mack uploaded patch set 3 01/09/20, 20:34
-
TYPO3com voted on patch set 3 V -1 01/09/20, 20:50 Completed build in 12m 32s on Thu, 9 Jan, 08:50 PM Test Summary: 38 of 68969 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39774
-
TYPO3com commented on patch set 3 01/10/20, 07:35 Completed build in 11h 10m 21s on Fri, 10 Jan, 07:35 AM Test Summary: 284 of 69247 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39774
-
TYPO3com voted on patch set 3 V +1 01/10/20, 09:27 Completed build in 0h 00m 02s on Fri, 10 Jan, 09:27 AM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39774
-
Jörg Bösche voted on patch set 3 CR +1 01/13/20, 12:38
-
Steffen Frese voted on patch set 3 CR +1 01/15/20, 09:54
-
Daniel Goerz voted on patch set 3 V +1 CR +1 01/15/20, 11:54
-
Susi Moog voted on patch set 3 V +2 CR +2 01/15/20, 14:09
-
Susi Moog merged patch set 4 01/15/20, 14:09
ActionController.php:172Unresolved