Review TYPO3_8-7 Merged

62784[BUGFIX] Test failure due to erroneous usage of uniqueId() function

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 12/30/19, 09:44

Commit message

The function in testing-framework provides a string that is target to be
used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it
to produce a random userId, which needs to be an integer.
If the randomly produced string contains not only numbers, the cast
operation converts the uid to 0 and therefor prevents a DB query
from execution. This prevention results in a not consumed mock object,
which in turn causes an integration test failure.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 712

  1. Anja Leichsenring uploaded patch set 1 12/30/19, 08:36

  2. TYPO3com voted on patch set 1 V +1 12/30/19, 08:49 Completed build in 09m 56s on Mon, 30 Dec, 08:49 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3812

  3. Benni Mack updated the commit message in patch set 2 12/30/19, 09:13

  4. Benni Mack updated the commit message in patch set 3 12/30/19, 09:21

  5. Benni Mack updated the commit message in patch set 4 12/30/19, 09:21

  6. Benni Mack updated the commit message in patch set 5 12/30/19, 09:22

  7. TYPO3com voted on patch set 2 V +1 12/30/19, 09:23 Completed build in 10m 26s on Mon, 30 Dec, 09:23 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3813

  8. TYPO3com voted on patch set 3 V +1 12/30/19, 09:38 Completed build in 16m 41s on Mon, 30 Dec, 09:38 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3815

  9. TYPO3com voted on patch set 4 V +1 12/30/19, 09:40 Completed build in 14m 08s on Mon, 30 Dec, 09:40 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3816

  10. TYPO3com voted on patch set 5 V +1 12/30/19, 09:44 Completed build in 18m 05s on Mon, 30 Dec, 09:44 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3817

  11. Benni Mack voted on patch set 5 V +2 CR +2 12/30/19, 09:44

  12. Benni Mack merged patch set 6 12/30/19, 09:44