Review main Merged

62785[TASK] Remove leftover "menu_type" occurrences

Benni Mack CR +2 V +2 Normal +1 −101 updated 12/30/19, 11:28

Commit message

With TYPO3 v8.6, the new Content Types for menus were introduced
where each menu type is not stored in the database field "menu_type"
anymore, but moved to a separate "CType" property. This change
was breaking, however some left-over code was there but never
removed. The code does not do anything anymore but handle the
special "menu_type" cases like in Page Module CType Previews
or categorization handling.

FYI: This is a pre-patch to streamline the category API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Benni Mack uploaded patch set 1 12/30/19, 08:46

  2. TYPO3com voted on patch set 1 V -1 12/30/19, 08:54 Completed build in 08m 02s on Mon, 30 Dec, 08:54 AM Test Summary: 68854 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39658

  3. TYPO3com voted on patch set 1 V +1 12/30/19, 09:02 Completed build in 23m 33s on Mon, 30 Dec, 09:02 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39658

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 12/30/19, 09:30

  5. Benjamin Kott voted on patch set 1 CR +1 12/30/19, 11:15

  6. Benjamin Kott voted on patch set 1 V +1 12/30/19, 11:16

  7. Benni Mack voted on patch set 1 V +2 CR +2 12/30/19, 11:28

  8. Benni Mack merged patch set 2 12/30/19, 11:28