Review main Merged

62789[TASK] Avoid buildAccessibleProxy in tests

Benni Mack CR +2 V +2 Normal +81 −125 updated 12/30/19, 11:20

Commit message

Tests should use getAccessibleMock() in all cases so
our testing API is used consistently everywhere.

The tests also show that some changes could be
made without having accessible proxies nowadays.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 57

  1. Benni Mack uploaded patch set 1 12/30/19, 10:50

  2. TYPO3com voted on patch set 1 V +1 12/30/19, 10:58 Completed build in 07m 09s on Mon, 30 Dec, 10:58 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39662

  3. Benni Mack updated the commit message in patch set 2 12/30/19, 10:59

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/30/19, 11:03

  5. TYPO3com voted on patch set 2 V +1 12/30/19, 11:07 Completed build in 08m 03s on Mon, 30 Dec, 11:07 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39663

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/30/19, 11:20

  7. Benni Mack merged patch set 3 12/30/19, 11:20