Review main Merged

62791[TASK] Use AJAX API in context menus

Andreas Kienast CR +2 V +2 Normal +59 −32 updated 01/17/20, 11:25

Commit message

The AJAX API is now used in context menus. This patch also incorporates
a neat ES6 feature to use variables in object keys in a sane way.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 89

  1. Andreas Kienast uploaded patch set 1 12/30/19, 17:00

  2. TYPO3com voted on patch set 1 V +1 12/30/19, 17:08 Completed build in 07m 31s on Mon, 30 Dec, 05:08 PM Test Summary: 69126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39668

  3. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 01/03/20, 22:25

  4. Oliver Hader commented on patch set 1 01/05/20, 17:19

    ContextMenuActions.ts:165

    This looks strange... array in object
  5. Oliver Hader commented on patch set 1 01/05/20, 17:30

    ContextMenuActions.ts:165 Reply

    Overlooked the order of nesting... (still it looks strange) Speaking about ES6, that could be [`FILE%7C${shortMD5}`] - couldn't it?
  6. Andreas Kienast commented on patch set 1 01/05/20, 17:52

    ContextMenuActions.ts:165 Reply

    The array thing is used to have variables in a key name. I may try the ${} syntax tomorrow.
  7. Andreas Kienast commented on patch set 1 01/06/20, 06:57

    ContextMenuActions.ts:165 Reply Unresolved

    Too bad, template literals don't work here.
  8. Frank Nägler voted on patch set 1 V +2 CR +2 01/17/20, 11:25

  9. Frank Nägler merged patch set 2 01/17/20, 11:25