Review TYPO3_8-7 Merged

62800[DOCS] Link to same version in documentation

Daniel Siepmann CR +2 V +2 Normal +14 −46 updated 01/14/20, 06:51

Commit message

Each documentation directory contains a Settings.cfg, which defines
the start urls to be used for intersphinx linking
(e.g. :ref:`t3corapi:something-or-other`).

In the official documentation we now link to same version of a manual
across manuals by using URLs with same version in Settings.cfg to fetch
the inventory. To make this consistent, we change this in the system
extensions as well.

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Sybille Peters +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1119

  1. Daniel Siepmann commented on patch set 1 01/07/20, 07:42

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/linkvalidator/Documentation/Settings.cfg * typo3/sysext/rsaauth/Documentation/Settings.cfg * typo3/sysext/seo/Documentation/Settings.cfg * typo3/sysext/workspaces/Documentation/Settings.cfg
  2. Daniel Siepmann commented on patch set 1 01/07/20, 07:42

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 01/07/20, 07:52 Completed build in 10m 06s on Tue, 7 Jan, 07:52 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3822

  4. Daniel Siepmann uploaded patch set 2 01/07/20, 07:56

  5. TYPO3com voted on patch set 2 V -1 01/07/20, 08:06 Completed build in 10m 05s on Tue, 7 Jan, 08:06 AM Test Summary: 92108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3823

  6. TYPO3com voted on patch set 2 V +1 01/07/20, 08:18 Completed build in 10m 14s on Tue, 7 Jan, 08:18 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3824

  7. Tymoteusz Motylewski commented on patch set 2 01/11/20, 07:52

    Settings.cfg:23

    do we need a trailing slash here?

    Settings.cfg:20

    same here

    Settings.cfg:17

    they are not used, right?
  8. Sybille Peters uploaded patch set 3 01/11/20, 08:25

  9. Sybille Peters uploaded patch set 4 01/11/20, 08:27

  10. Sybille Peters uploaded patch set 5 01/11/20, 08:28

  11. Sybille Peters commented on patch set 5 CR +1 01/11/20, 08:29

    Settings.cfg:23 Reply

    Done

    Settings.cfg:20 Reply

    Done

    Settings.cfg:17 Reply

    Yes. I grepped.
  12. TYPO3com voted on patch set 3 V -1 01/11/20, 08:34 Completed build in 08m 57s on Sat, 11 Jan, 08:34 AM Test Summary: 101284 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3829

  13. Sybille Peters commented on patch set 5 01/11/20, 08:40

    Settings.cfg:23 Reply

    About the trailing slash: It currently also works without, but of course for consistency reasons I fixed this. tips: - If there is an error fetching the interspinx repository or a reference can not be resolved, there will be warnings in Documentation-GENERATED-temp/Result/project/0.0.0/_buildinfo/warnings.txt - to get a full list, you MUST remove the Documentation-GENERATED-temp before building - otherwise, because of caching - you may not get a complete list
  14. TYPO3com voted on patch set 4 V -1 01/11/20, 08:41 Completed build in 12m 58s on Sat, 11 Jan, 08:41 AM Test Summary: 91293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3830

  15. TYPO3com voted on patch set 5 V -1 01/11/20, 08:44 Completed build in 10m 58s on Sat, 11 Jan, 08:44 AM Test Summary: 100864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3831

  16. TYPO3com commented on patch set 5 01/11/20, 09:14 Completed build in 09m 42s on Sat, 11 Jan, 09:14 AM Test Summary: 91774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3832

  17. TYPO3com voted on patch set 5 V +1 01/12/20, 15:29 Completed build in 6h 34m 08s on Sun, 12 Jan, 03:29 PM Test Summary: 101771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3832

  18. Daniel Siepmann voted on patch set 5 V +2 CR +2 01/14/20, 06:50

  19. Daniel Siepmann merged patch set 6 01/14/20, 06:51