Review 9.5 Merged

62801[BUGFIX] Ensure fresh logger instance in scheduler tasks

Benni Mack CR +2 V +2 Easy +13 −29 updated 01/10/20, 10:02

Commit message

The AbstractTask always had methods setScheduler and
unsetScheduler to avoid serialization of the scheduler instance.
These methods are called by the scheduler API before serializing
(unset) and after unserializing (set).

Use these methods in favor of the __sleep and __wakup calls
to avoid issues with third party subclasses that implement these methods
and to make sure tasks that are already serialized with an outdated
logger instance are properly updated on next run without the need
to clean them up manually.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 01/09/20, 20:28

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extensionmanager/Tests/Unit/Task/UpdateExtensionListTaskTest.php
  2. TYPO3com voted on patch set 1 V -1 01/09/20, 20:28 Completed build in 12s on Thu, 9 Jan, 08:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1778

  3. Benni Mack commented on patch set 2 01/10/20, 09:02

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 01/10/20, 09:02

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 01/10/20, 09:49 Completed build in 36m 59s on Fri, 10 Jan, 09:49 AM Test Summary: 72668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1781

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/10/20, 10:02

  7. Benni Mack merged patch set 3 01/10/20, 10:02