Review 9.5 Merged

62802[BUGFIX] Correctly display the CGI environment in Environment module

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/10/20, 09:29

Commit message

During the TYPO3 v9 install tool refactoring, a simple PHP array syntax
mistake did not correctly set the fluid variable "systemInformationCgiDetected"
which always resulted in not running in a CGI environment.

The change adapts the array variable assignment.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 47

  1. Benni Mack commented on patch set 1 01/10/20, 09:01

    Cherry Picked from branch master.
  2. Benni Mack updated the commit message in patch set 2 01/10/20, 09:01

  3. TYPO3com voted on patch set 1 V -1 01/10/20, 09:15 Completed build in 14m 01s on Fri, 10 Jan, 09:15 AM Test Summary: 72333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1779

  4. TYPO3com voted on patch set 2 V +1 01/10/20, 09:21 Completed build in 20m 18s on Fri, 10 Jan, 09:21 AM Test Summary: 72668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1780

  5. Benni Mack voted on patch set 2 V +2 CR +2 01/10/20, 09:22

  6. Benni Mack merged patch set 3 01/10/20, 09:22

  7. TYPO3com voted on patch set 1 V +1 01/10/20, 09:29 Completed build in 42m 28s on Fri, 10 Jan, 09:29 AM Test Summary: 72668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1779