Review 9.5 Merged

62805[BUGFIX] Fix OptimizeDatabaseTableTask for PDO and MySQLi

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 01/10/20, 15:21

Commit message

With this change $connection::query() is used instead of
$connection::exec() which can not be used for statements
that return results, see:

https://www.php.net/manual/de/pdo.exec.php#61702

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 36

  1. Andreas Kienast commented on patch set 1 01/10/20, 14:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 01/10/20, 15:05 Completed build in 15m 18s on Fri, 10 Jan, 03:05 PM Test Summary: 61035 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1783

  3. TYPO3com commented on patch set 1 01/10/20, 15:14 Completed build in 40m 05s on Fri, 10 Jan, 03:14 PM Test Summary: 72344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1783

  4. TYPO3com voted on patch set 1 V +1 01/10/20, 15:20 Completed build in 1h 10m 44s on Fri, 10 Jan, 03:20 PM Test Summary: 72680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1783

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 01/10/20, 15:21

  6. Andreas Kienast merged patch set 2 01/10/20, 15:21