Review TYPO3_8-7 Merged

62806[BUGFIX] Fix OptimizeDatabaseTableTask for PDO and MySQLi

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 01/10/20, 15:21

Commit message

With this change $connection::query() is used instead of
$connection::exec() which can not be used for statements
that return results, see:

https://www.php.net/manual/de/pdo.exec.php#61702

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 01/10/20, 14:50

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V -1 01/10/20, 15:00 Completed build in 10m 25s on Fri, 10 Jan, 03:00 PM Test Summary: 91901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3828

  3. TYPO3com voted on patch set 1 V +1 01/10/20, 15:05 Completed build in 25m 39s on Fri, 10 Jan, 03:05 PM Test Summary: 101771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3828

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 01/10/20, 15:21

  5. Andreas Kienast merged patch set 2 01/10/20, 15:21