Review 9.5 Merged

62807[BUGFIX] Do not pass extTarget by reference

Daniel Goerz CR +2 V +2 Easy +3 −1 updated 01/12/20, 19:04

Commit message

As config.extTarget might not be set, passing
it by reference results in the string "< config.extTarget"
being passed instead - which will not evaluate to empty
therefor breaking the fallback chain.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 01/12/20, 16:36

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/12/20, 16:45 Completed build in 09m 49s on Sun, 12 Jan, 04:45 PM Test Summary: 72680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1786

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 01/12/20, 19:04

  4. Daniel Goerz merged patch set 2 01/12/20, 19:04