Review main Merged

62812[BUGFIX] Use correct variable naming for PID value in DataHandler

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/01/20, 11:13

Commit message

The change of issue #90019 introduced a mis-spelling in hte variable naming,
where the variable was named "$tscPid" but the original code was "$tscPID"
which should be used as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +2
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +2
    • Rudy Gnodde +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Benni Mack uploaded patch set 1 12/31/19, 11:49

  2. Benni Mack updated the commit message in patch set 2 12/31/19, 11:50

  3. Oliver Hader voted on patch set 2 V +1 CR +1 12/31/19, 11:57

  4. TYPO3com voted on patch set 1 V +1 12/31/19, 11:58 Completed build in 09m 39s on Tue, 31 Dec, 11:58 AM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39676

  5. Rudy Gnodde voted on patch set 2 V +1 CR +1 12/31/19, 12:01

  6. TYPO3com voted on patch set 2 V +1 12/31/19, 12:01 Completed build in 11m 49s on Tue, 31 Dec, 12:01 PM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39677

  7. Benni Mack voted on patch set 2 V +2 CR +2 12/31/19, 12:09

  8. Oliver Hader voted on patch set 2 V +2 CR +2 12/31/19, 12:09

  9. Oliver Hader merged patch set 3 12/31/19, 12:09

  10. Oliver Klee commented on patch set 3 01/01/20, 11:13

    Unresolved

    I like the self-referential misspelling of "the" ("hte") here. ;-)