Review main Merged

62815[TASK] Refactor route enhancer tests

Oliver Hader CR +2 V +2 Nightmare +2040 −821 updated 01/14/20, 09:18

Commit message

* replaces nested array logic with domain objects
* introduces perputation logic (instead of foreach/foreach/foreach/...)
* introduced common variables container compiled when executing tests
  (allows to declare arbitrary behaviour without hardcoding values)
* applies more specific page type decorators in request tests

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Felix P. +1
    • Susi Moog +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Felix P. +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 2955

Show 1430 earlier messages
  1. Oliver Hader uploaded patch set 1 01/03/20, 14:38

  2. TYPO3com voted on patch set 1 V -1 01/03/20, 14:46 Completed build in 07m 18s on Fri, 3 Jan, 02:46 PM Test Summary: 90 of 69596 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39688

  3. Oliver Hader uploaded patch set 2 01/03/20, 17:19

  4. TYPO3com voted on patch set 2 V -1 01/03/20, 17:19 Completed build in 13s on Fri, 3 Jan, 05:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39690

  5. Oliver Hader uploaded patch set 3 01/03/20, 17:32

  6. TYPO3com voted on patch set 3 V -1 01/03/20, 17:32 Completed build in 12s on Fri, 3 Jan, 05:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39691

  7. Oliver Hader uploaded patch set 4 01/03/20, 17:34

  8. TYPO3com voted on patch set 4 V -1 01/03/20, 17:34 Completed build in 12s on Fri, 3 Jan, 05:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39692

  9. Oliver Hader uploaded patch set 5 01/03/20, 17:37

  10. Oliver Hader commented on patch set 5 01/03/20, 17:38

    ... and on top of that, possibility to merge route defaults and requirements - and permute all of those
  11. TYPO3com voted on patch set 5 V +1 01/03/20, 17:45 Completed build in 07m 53s on Fri, 3 Jan, 05:45 PM Test Summary: 68516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39693

  12. Oliver Hader uploaded patch set 6 01/03/20, 18:28

  13. Oliver Hader updated the commit message in patch set 7 01/03/20, 18:33

  14. TYPO3com voted on patch set 6 V +1 01/03/20, 18:36 Completed build in 07m 53s on Fri, 3 Jan, 06:36 PM Test Summary: 68876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39694

  15. TYPO3com voted on patch set 7 V +1 01/03/20, 18:41 Completed build in 07m 20s on Fri, 3 Jan, 06:41 PM Test Summary: 68876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39695

  16. Oliver Hader uploaded patch set 8 01/04/20, 12:27

  17. TYPO3com voted on patch set 8 V -1 01/04/20, 12:28 Completed build in 12s on Sat, 4 Jan, 12:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39699

  18. Oliver Hader uploaded patch set 9 01/04/20, 12:29

  19. TYPO3com voted on patch set 9 V -1 01/04/20, 12:37 Completed build in 08m 09s on Sat, 4 Jan, 12:37 PM Test Summary: 69151 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  20. TYPO3com commented on patch set 9 01/04/20, 12:41 Completed build in 20m 21s on Sat, 4 Jan, 12:41 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  21. TYPO3com commented on patch set 9 01/04/20, 12:47 Completed build in 39m 05s on Sat, 4 Jan, 12:47 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  22. TYPO3com commented on patch set 9 01/04/20, 14:07 Completed build in 2h 17m 38s on Sat, 4 Jan, 02:07 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  23. TYPO3com commented on patch set 9 01/04/20, 14:08 Completed build in 3h 56m 32s on Sat, 4 Jan, 02:08 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  24. TYPO3com commented on patch set 9 01/04/20, 14:08 Completed build in 5h 35m 43s on Sat, 4 Jan, 02:08 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  25. Oliver Hader commented on patch set 9 01/04/20, 14:08

    Stupid Bamboo!!
  26. TYPO3com commented on patch set 9 01/04/20, 14:08 Completed build in 7h 15m 19s on Sat, 4 Jan, 02:08 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  27. Oliver Hader commented on patch set 9 01/04/20, 14:09

    ``` Error: No such container: agent07sib_adhoc agent07.srv003.typo3.com ```
  28. TYPO3com commented on patch set 9 01/04/20, 14:09 Completed build in 8h 55m 49s on Sat, 4 Jan, 02:09 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39700

  29. Oliver Hader uploaded patch set 10 01/04/20, 14:13

  30. Oliver Hader updated the commit message in patch set 11 01/04/20, 14:14

  1. TYPO3com voted on patch set 10 V -1 01/04/20, 14:22 Completed build in 08m 50s on Sat, 4 Jan, 02:22 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39701

  2. TYPO3com voted on patch set 11 V -1 01/04/20, 14:25 Completed build in 10m 59s on Sat, 4 Jan, 02:25 PM Test Summary: 69434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39702

  3. Oliver Hader uploaded patch set 12 01/04/20, 18:24

  4. TYPO3com voted on patch set 12 V -1 01/04/20, 18:30 Completed build in 06m 22s on Sat, 4 Jan, 06:30 PM Test Summary: 60820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39706

  5. TYPO3com commented on patch set 12 01/04/20, 18:38 Completed build in 20m 44s on Sat, 4 Jan, 06:38 PM Test Summary: 60820 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39706

  6. Oliver Hader uploaded patch set 13 01/04/20, 18:39

  7. TYPO3com voted on patch set 13 V +1 01/04/20, 18:49 Completed build in 10m 15s on Sat, 4 Jan, 06:49 PM Test Summary: 69432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39709

  8. Oliver Hader commented on patch set 13 01/04/20, 20:05

    → extracted permutation helpers in https://review.typo3.org/c/Packages/TYPO3.CMS/+/62819
  9. Oliver Hader uploaded patch set 14 01/06/20, 11:58

  10. TYPO3com voted on patch set 14 V -1 01/06/20, 12:03 Completed build in 05m 17s on Mon, 6 Jan, 12:03 PM Test Summary: 60822 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39719

  11. Oliver Hader commented on patch set 14 01/06/20, 12:09

    Builder.php:3

    Not sure yet about the namespace here... it could be located in some SiteHandling\Framework as well (since it might be useful for other tests). I'm reluctant of putting it to the testing framework with would define additional dependencies and releases in case of further enhancements...
  12. Oliver Hader rebased onto patch set 15 01/06/20, 15:06

  13. TYPO3com voted on patch set 15 V +1 01/06/20, 15:15 Completed build in 08m 00s on Mon, 6 Jan, 03:15 PM Test Summary: 69530 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39725

  14. Susi Moog commented on patch set 15 01/13/20, 17:15

    Builder.php:3 Reply Unresolved

    TYPO3\CMS\Frontend\Tests\Functional\SiteHandling\Framework\Builder <<
  15. Oliver Hader uploaded patch set 16 01/13/20, 17:58

  16. TYPO3com voted on patch set 16 V -1 01/13/20, 17:59 Completed build in 13s on Mon, 13 Jan, 05:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39874

  17. Oliver Hader uploaded patch set 17 01/13/20, 18:01

  18. TYPO3com voted on patch set 17 V -1 01/13/20, 18:09 Completed build in 07m 16s on Mon, 13 Jan, 06:09 PM Test Summary: 59419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39875

  19. Oliver Hader uploaded patch set 18 01/13/20, 19:38

  20. TYPO3com voted on patch set 18 V +1 01/13/20, 19:46 Completed build in 08m 43s on Mon, 13 Jan, 07:46 PM Test Summary: 69494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39881

  21. Susi Moog voted on patch set 18 V +1 CR +1 01/13/20, 21:31

  22. Felix P. voted on patch set 18 V +1 CR +1 01/14/20, 07:34

  23. Tobi Kretschmann voted on patch set 18 V +2 01/14/20, 09:10

  24. Tobi Kretschmann voted on patch set 18 CR +2 01/14/20, 09:18

  25. Tobi Kretschmann merged patch set 19 01/14/20, 09:18