Review main Merged

62816[FEATURE] Add form configuration to configuration module

Chris Müller CR +2 V +2 Easy +42 −0 updated 01/16/20, 10:17

Commit message

The debugging of the yaml configuration of the form extension can be
hard. To ease this task the configuration is available in the
configuration module of the lowlevel extension.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Guido Schmechel +1
    • Benni Mack +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Susi Moog +2
    • Guido Schmechel +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 912

  1. Chris Müller uploaded patch set 1 01/03/20, 20:11

  2. TYPO3com voted on patch set 1 V -1 01/03/20, 20:28 Completed build in 16m 49s on Fri, 3 Jan, 08:28 PM Test Summary: 5 of 69307 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39696

  3. TYPO3com voted on patch set 1 V +1 01/03/20, 20:54 Completed build in 11m 00s on Fri, 3 Jan, 08:54 PM Test Summary: 69146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39697

  4. Guido Schmechel commented on patch set 1 01/03/20, 21:49

    Nice idea and the implementation works, too. However, the guidelines require an RST file for features.
  5. Chris Müller uploaded patch set 2 01/04/20, 18:13

  6. Chris Müller commented on patch set 2 01/04/20, 18:14

    > Patch Set 1: > > Nice idea and the implementation works, too. However, the guidelines require an RST file for features. Thanks for the hint, I added the rst and also added a tip in the form documentation about this feature.
  7. TYPO3com voted on patch set 2 V +1 01/04/20, 18:21 Completed build in 08m 22s on Sat, 4 Jan, 06:21 PM Test Summary: 69146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39705

  8. Guido Schmechel voted on patch set 2 V +1 CR +1 01/05/20, 10:46

  9. Benni Mack commented on patch set 2 CR +1 01/05/20, 22:24

    In general this is really cool. I'd love to have EXT:lowlevel to allow extensions to hook in but this should be tackled separately (which I have some ideas in my head, but it's a separate, larger topic). for now, this is really good!
  10. Steffen Frese voted on patch set 2 V +1 CR +1 01/16/20, 09:38

  11. Susi Moog voted on patch set 2 V +2 CR +2 01/16/20, 10:17

  12. Susi Moog merged patch set 3 01/16/20, 10:17