62819[TASK] Introduce PermutationUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2939
Show 914 earlier messages
-
Oliver Hader uploaded patch set 1 01/04/20, 20:05
-
TYPO3com voted on patch set 1 V -1 01/04/20, 20:05 Completed build in 16s on Sat, 4 Jan, 08:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39710
-
Oliver Hader commented on patch set 1 01/04/20, 20:06
... -
Oliver Hader uploaded patch set 2 01/04/20, 20:07
-
Oliver Hader voted on patch set 2 V +1 01/04/20, 20:07
-
TYPO3com voted on patch set 2 V -1 01/04/20, 20:19 Completed build in 12m 47s on Sat, 4 Jan, 08:19 PM Test Summary: 2 of 69686 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39711
-
TYPO3com commented on patch set 2 01/04/20, 20:51 Completed build in 56m 35s on Sat, 4 Jan, 08:50 PM Test Summary: 69236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39711
-
Oliver Hader commented on patch set 2 01/04/20, 20:57
Duplicate exception code 1578164102 in file: sysext/core/Tests/Unit/Utility/PermutationUtilityTest.php 😂 -
Oliver Hader uploaded patch set 3 01/04/20, 20:59
-
Oliver Hader commented on patch set 3 01/04/20, 20:59
Next try... -
Oliver Hader commented on patch set 3 01/04/20, 21:03
``` ERROR: for agent15sib_mariadb10_1 UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60) ``` -
TYPO3com voted on patch set 3 V -1 01/04/20, 21:10 Completed build in 11m 23s on Sat, 4 Jan, 09:10 PM Test Summary: 68954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39712
-
TYPO3com voted on patch set 3 V +1 01/04/20, 21:12 Completed build in 25m 09s on Sat, 4 Jan, 09:12 PM Test Summary: 69236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39712
-
Oliver Hader commented on patch set 3 V +1 01/04/20, 21:13
Finally...
-
Benni Mack commented on patch set 3 01/05/20, 21:37
PermutationUtility.php:2strict typesPermutationUtility.php:39use "(!empty($payload))" instead of count, which is faster.PermutationUtility.php:94": string" ?AbstractTestCase.php:76what's with the "finalCallback" logic? -
Benni Mack commented on patch set 3 CR -1 01/05/20, 21:37
in general, that's really good, as I had to look for the meltStrings logic in a lot of places when writing new tests. -
Oliver Hader commented on patch set 3 01/06/20, 10:21
PermutationUtility.php:2ReplyAck -
Oliver Hader commented on patch set 3 01/06/20, 10:22
PermutationUtility.php:39ReplyAck -
Oliver Hader commented on patch set 3 01/06/20, 10:22
PermutationUtility.php:94ReplyAck -
Oliver Hader commented on patch set 3 01/06/20, 10:25
AbstractTestCase.php:76Reply UnresolvedNot used anymore. This callback stems from earlier versions of routing tests that have not been cleaned up afterwards... In a separate patch I'd completely remove this method and replace it with direct invocation of the new PermutationUtility. -
Oliver Hader uploaded patch set 4 01/06/20, 10:26
-
Oliver Hader commented on patch set 4 01/06/20, 10:30
PermutationUtilityTest.php:104UnresolvedForgot to change this annotation -
Oliver Hader uploaded patch set 5 01/06/20, 10:30
-
TYPO3com voted on patch set 4 V -1 01/06/20, 10:35 Completed build in 08m 49s on Mon, 6 Jan, 10:35 AM Test Summary: 59159 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39713
-
TYPO3com voted on patch set 4 V +1 01/06/20, 10:38 Completed build in 19m 59s on Mon, 6 Jan, 10:38 AM Test Summary: 69236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39713
-
TYPO3com voted on patch set 5 V -1 01/06/20, 10:39 Completed build in 08m 59s on Mon, 6 Jan, 10:39 AM Test Summary: 69142 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39714
-
TYPO3com voted on patch set 5 V +1 01/06/20, 10:44 Completed build in 22m 07s on Mon, 6 Jan, 10:44 AM Test Summary: 69236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39714
-
Benni Mack voted on patch set 5 V +1 CR +1 01/06/20, 11:04
-
Andreas Kienast commented on patch set 5 01/06/20, 11:18
PermutationUtilityTest.php:1declare strict?PermutationUtilityTest.php:109: void?PermutationUtilityTest.php:193: void? -
Oliver Hader commented on patch set 5 01/06/20, 11:33
PermutationUtilityTest.php:1ReplyAckPermutationUtilityTest.php:109ReplyAckPermutationUtilityTest.php:193ReplyAck -
Oliver Hader uploaded patch set 6 01/06/20, 11:34
-
TYPO3com voted on patch set 6 V +1 01/06/20, 11:43 Completed build in 08m 23s on Mon, 6 Jan, 11:43 AM Test Summary: 69236 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39716
-
Oliver Klee commented on patch set 6 01/06/20, 11:57
AbstractTestCase.php:72Is this change still WIP? -
Andreas Kienast voted on patch set 6 V +1 CR +1 01/06/20, 11:57
-
Oliver Hader commented on patch set 6 01/06/20, 12:00
> Patch Set 6: > > (1 comment)AbstractTestCase.php:72Reply -
Oliver Hader commented on patch set 6 01/06/20, 12:01
AbstractTestCase.php:72Reply Unresolved→ https://review.typo3.org/c/Packages/TYPO3.CMS/+/62821 contains the actual change which drops this method -
Oliver Klee commented on patch set 6 01/06/20, 12:05
Ah, okay, I see. Thanks for the quick reply. -
Benni Mack voted on patch set 6 V +2 CR +2 01/06/20, 12:44
-
Benni Mack merged patch set 7 01/06/20, 12:44