62825[BUGFIX] Do not ignore array-like site configuration values
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1922
-
Claus Due uploaded patch set 1 01/06/20, 16:24
-
TYPO3com voted on patch set 1 V -1 01/06/20, 16:31 Completed build in 06m 56s on Mon, 6 Jan, 04:31 PM Test Summary: 6 of 69692 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39726
-
Claus Due uploaded patch set 2 01/06/20, 16:40
-
TYPO3com voted on patch set 2 V +1 01/06/20, 16:48 Completed build in 07m 15s on Mon, 6 Jan, 04:48 PM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39727
-
Benni Mack voted on patch set 2 CR +1 01/30/20, 13:18
-
Guido Schmechel voted on patch set 2 CR +1 04/14/20, 12:56
-
Oli Bartsch commented on patch set 2 04/19/20, 11:17
-
Claus Due commented on patch set 2 04/19/20, 11:26
SiteDatabaseEditRow.php:80ReplyUnion gets the same job done. -
Claus Due commented on patch set 2 04/19/20, 11:29
Here's the opcode difference: array_merge(): 3 0 E > INIT_FCALL 'array_merge' 1 SEND_VAL <array> 2 SEND_VAL <array> 3 DO_ICALL $1 4 ASSIGN !0, $1 union: 4 5 ASSIGN !0, <array> -
Oli Bartsch commented on patch set 2 CR +1 04/19/20, 11:43
SiteDatabaseEditRow.php:80ReplyAck -
Oliver Klee voted on patch set 2 CR +1 04/19/20, 12:03
-
Wouter Wolters voted on patch set 2 CR +1 04/20/20, 18:29
-
Benni Mack updated the commit message in patch set 3 05/25/20, 18:47
-
Benni Mack commented on patch set 3 11/10/21, 21:21
ping. Is anyone willing to continue on this? -
Benni Mack rebased onto patch set 4 11/10/21, 21:21
-
Christian Kuhn commented on patch set 4 11/10/21, 21:30
Note: This was the result of a design decision with first site handling module: people *can* add fields, but only simple things. When we relax that and allow for instance type=select, this may break loose a lot of issues in the handling. So, I'm not sure on the impact, and this needs thoughts before merge. -
core-ci voted on patch set 4 V +1 11/10/21, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19154
-
Benni Mack wrote 11/29/21, 10:14
Change destination moved from master to main -
Benni Mack wrote 11/30/21, 11:45
Removed reviewer Benni Mack. -
Christian Kuhn commented on patch set 4 CR -1 12/08/21, 21:38
-1 question from my above comment remains. -
Christian Kuhn commented on patch set 4 12/08/21, 21:40
will abandon due to lack of feedback for now. please feel free to resurrect or repush a solution to rediscuss. -
Christian Kuhn abandoned the change 12/08/21, 21:40
SiteDatabaseEditRow.php:80