Review main Abandoned

62825[BUGFIX] Do not ignore array-like site configuration values

Claus Due CR 0 V 0 Easy +5 −6 updated 12/08/21, 21:40

Commit message

This patch removes an intentional exclusion of any
and all array-like values stored in site-configuration
YAML files and replaces a redundant loop with
array union.

Ignoring such values causes any multi-option select
field to be inoperable in site configuration pseudo-TCA,
since after saving the values, the field will not be
rendered with selected options. The field always appears
to have no selected values.

This in turn causes multi-option select fields to be
inoperable in site-configuration since any reload of the
form causes already selected options to be no longer
selected, which then empties the field value on save.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1922

  1. Claus Due uploaded patch set 1 01/06/20, 16:24

  2. TYPO3com voted on patch set 1 V -1 01/06/20, 16:31 Completed build in 06m 56s on Mon, 6 Jan, 04:31 PM Test Summary: 6 of 69692 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39726

  3. Claus Due uploaded patch set 2 01/06/20, 16:40

  4. TYPO3com voted on patch set 2 V +1 01/06/20, 16:48 Completed build in 07m 15s on Mon, 6 Jan, 04:48 PM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39727

  5. Benni Mack voted on patch set 2 CR +1 01/30/20, 13:18

  6. Guido Schmechel voted on patch set 2 CR +1 04/14/20, 12:56

  7. Oli Bartsch commented on patch set 2 04/19/20, 11:17

    SiteDatabaseEditRow.php:80

    Why no `array_merge`?
  8. Claus Due commented on patch set 2 04/19/20, 11:26

    SiteDatabaseEditRow.php:80 Reply

    Union gets the same job done.
  9. Claus Due commented on patch set 2 04/19/20, 11:29

    Here's the opcode difference: array_merge(): 3 0 E > INIT_FCALL 'array_merge' 1 SEND_VAL <array> 2 SEND_VAL <array> 3 DO_ICALL $1 4 ASSIGN !0, $1 union: 4 5 ASSIGN !0, <array>
  10. Oli Bartsch commented on patch set 2 CR +1 04/19/20, 11:43

    SiteDatabaseEditRow.php:80 Reply

    Ack
  11. Oliver Klee voted on patch set 2 CR +1 04/19/20, 12:03

  12. Wouter Wolters voted on patch set 2 CR +1 04/20/20, 18:29

  13. Benni Mack updated the commit message in patch set 3 05/25/20, 18:47

  14. Benni Mack commented on patch set 3 11/10/21, 21:21

    ping. Is anyone willing to continue on this?
  15. Benni Mack rebased onto patch set 4 11/10/21, 21:21

  16. Christian Kuhn commented on patch set 4 11/10/21, 21:30

    Note: This was the result of a design decision with first site handling module: people *can* add fields, but only simple things. When we relax that and allow for instance type=select, this may break loose a lot of issues in the handling. So, I'm not sure on the impact, and this needs thoughts before merge.
  17. core-ci voted on patch set 4 V +1 11/10/21, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19154

  18. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  19. Benni Mack wrote 11/30/21, 11:45

    Removed reviewer Benni Mack.
  20. Christian Kuhn commented on patch set 4 CR -1 12/08/21, 21:38

    -1 question from my above comment remains.
  21. Christian Kuhn commented on patch set 4 12/08/21, 21:40

    will abandon due to lack of feedback for now. please feel free to resurrect or repush a solution to rediscuss.
  22. Christian Kuhn abandoned the change 12/08/21, 21:40