62828[BUGFIX] Return expected value on GU::writeFileToTypo3tempDir success
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 711
-
Rémy DANIEL uploaded patch set 1 01/07/20, 10:14
-
TYPO3com voted on patch set 1 V -1 01/07/20, 10:14 Completed build in 26s on Tue, 7 Jan, 10:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39732
-
Rémy DANIEL uploaded patch set 2 01/07/20, 10:37
-
TYPO3com voted on patch set 2 V +1 01/07/20, 10:46 Completed build in 08m 33s on Tue, 7 Jan, 10:46 AM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39734
-
Simon Gilli commented on patch set 2 01/07/20, 11:00
-
Rémy DANIEL updated the commit message in patch set 3 01/07/20, 11:02
-
Anja Leichsenring updated the commit message in patch set 4 01/07/20, 11:05
-
Rémy DANIEL commented on patch set 4 CR -1 01/07/20, 11:07
> Patch Set 2: > > (1 comment) You are absolutely right. The php_cs forced me to rewrite and I omitted that break. But when I add it again, php_cs complains again. I will try to make it happy again! -
TYPO3com voted on patch set 3 V -1 01/07/20, 11:10 Completed build in 08m 40s on Tue, 7 Jan, 11:10 AM Test Summary: 69239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39735
-
TYPO3com voted on patch set 4 V -1 01/07/20, 11:15 Completed build in 09m 42s on Tue, 7 Jan, 11:15 AM Test Summary: 68967 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39736
-
Anja Leichsenring abandoned the change 01/07/20, 12:31
abandoned by request of author
GeneralUtility.php:2022Unresolved