Review main Abandoned

62828[BUGFIX] Return expected value on GU::writeFileToTypo3tempDir success

Rémy DANIEL CR 0 V 0 Easy +5 −0 updated 01/07/20, 12:31

Commit message

When TYPO3 is in composer mode (var is outside public path),
GeneralUtility::writeFileToTypo3tempDir() now returns NULL for
successful operation as stated in the docblock.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 711

  1. Rémy DANIEL uploaded patch set 1 01/07/20, 10:14

  2. TYPO3com voted on patch set 1 V -1 01/07/20, 10:14 Completed build in 26s on Tue, 7 Jan, 10:14 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39732

  3. Rémy DANIEL uploaded patch set 2 01/07/20, 10:37

  4. TYPO3com voted on patch set 2 V +1 01/07/20, 10:46 Completed build in 08m 33s on Tue, 7 Jan, 10:46 AM Test Summary: 69248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39734

  5. Simon Gilli commented on patch set 2 01/07/20, 11:00

    GeneralUtility.php:2022 Unresolved

    Imho a break is now missing here
  6. Rémy DANIEL updated the commit message in patch set 3 01/07/20, 11:02

  7. Anja Leichsenring updated the commit message in patch set 4 01/07/20, 11:05

  8. Rémy DANIEL commented on patch set 4 CR -1 01/07/20, 11:07

    > Patch Set 2: > > (1 comment) You are absolutely right. The php_cs forced me to rewrite and I omitted that break. But when I add it again, php_cs complains again. I will try to make it happy again!
  9. TYPO3com voted on patch set 3 V -1 01/07/20, 11:10 Completed build in 08m 40s on Tue, 7 Jan, 11:10 AM Test Summary: 69239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39735

  10. TYPO3com voted on patch set 4 V -1 01/07/20, 11:15 Completed build in 09m 42s on Tue, 7 Jan, 11:15 AM Test Summary: 68967 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39736

  11. Anja Leichsenring abandoned the change 01/07/20, 12:31

    abandoned by request of author