Review main Merged

62830[TASK] Clean up RelationHandler variable assignments

Benni Mack CR +2 V +2 Easy +11 −15 updated 01/10/20, 09:31

Commit message

This change cleans up some RelationHandler code:
- Working with true boolean inside RelationHandler for getValueArray()
- RelationHandler->MM_oppositeFieldConf is an array, but declared wrongly
as string (since forever!)
- detecting the MM_oppositeTable property should not need a $tmp variable,
  but using a direct assignment - and unset() is not needed due to PHP7s memory management
- internal $isSet flags should be boolean, instead of a number

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Benni Mack uploaded patch set 1 01/08/20, 08:01

  2. TYPO3com voted on patch set 1 V +1 01/08/20, 08:09 Completed build in 07m 25s on Wed, 8 Jan, 08:09 AM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39752

  3. Oliver Klee voted on patch set 1 CR +1 01/08/20, 10:52

  4. Oliver Klee commented on patch set 1 CR 0 01/08/20, 10:53

    There seem to be some words missing here.
  5. Benni Mack updated the commit message in patch set 2 01/08/20, 11:09

  6. Benni Mack commented on patch set 2 01/08/20, 11:09

    Reply

    THANKS!
  7. Oliver Klee voted on patch set 2 CR +1 01/08/20, 11:18

  8. TYPO3com voted on patch set 2 V +1 01/08/20, 11:20 Completed build in 10m 04s on Wed, 8 Jan, 11:20 AM Test Summary: 69197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39756

  9. Georg Ringer voted on patch set 2 V +1 CR +1 01/08/20, 11:38

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/10/20, 09:31

  11. Anja Leichsenring merged patch set 3 01/10/20, 09:31