Review main Merged

62833[BUGFIX] Check return value of inet_pton in IpAnonymizationUtility

Georg Ringer CR +2 V +2 Easy +6 −1 updated 01/10/20, 09:28

Commit message

The method inet_pton returns false if the provided IP address is
invalid. This needs to be checked to avoid errors.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1119

  1. Georg Ringer uploaded patch set 1 01/08/20, 21:04

  2. Georg Ringer commented on patch set 1 01/08/20, 21:05

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 01/08/20, 21:15 Completed build in 10m 12s on Wed, 8 Jan, 09:15 PM Test Summary: 4 of 69659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39762

  4. Benni Mack commented on patch set 1 01/09/20, 14:22

    I love how this fails on travis, but not for my local machine --- (*not*).
  5. TYPO3com commented on patch set 1 01/09/20, 14:23 Completed build in 17h 28m 46s on Thu, 9 Jan, 02:23 PM Test Summary: 4 of 69659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39762

  6. Markus Klein commented on patch set 1 01/09/20, 20:27

    I can verify the problem with a docker container based on php:7.2-apache
  7. Markus Klein commented on patch set 2 01/09/20, 20:28

    Published edit on patch set 1.
  8. Markus Klein voted on patch set 2 V +1 CR +1 01/09/20, 20:33

  9. TYPO3com voted on patch set 2 V -1 01/09/20, 20:44 Completed build in 15m 39s on Thu, 9 Jan, 08:44 PM Test Summary: 50 of 69353 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39773

  10. TYPO3com commented on patch set 2 01/09/20, 20:54 Completed build in 41m 21s on Thu, 9 Jan, 08:54 PM Test Summary: 2 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39773

  11. TYPO3com commented on patch set 2 01/09/20, 20:55 Completed build in 1h 08m 26s on Thu, 9 Jan, 08:55 PM Test Summary: 3 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39773

  12. TYPO3com commented on patch set 2 01/09/20, 22:42 Completed build in 3h 22m 31s on Thu, 9 Jan, 10:42 PM Test Summary: 3 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39773

  13. Markus Klein rebased onto patch set 3 01/09/20, 22:42

  14. TYPO3com voted on patch set 3 V -1 01/09/20, 22:54 Completed build in 12m 06s on Thu, 9 Jan, 10:54 PM Test Summary: 28 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39775

  15. TYPO3com voted on patch set 3 V +1 01/10/20, 08:51 Completed build in 10h 21m 10s on Fri, 10 Jan, 08:51 AM Test Summary: 69191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39775

  16. Benni Mack voted on patch set 3 V +1 CR +1 01/10/20, 09:14

  17. Markus Klein voted on patch set 3 V +1 CR +1 01/10/20, 09:26

  18. Benni Mack voted on patch set 3 V +2 CR +2 01/10/20, 09:28

  19. Benni Mack merged patch set 4 01/10/20, 09:28