Review main Merged

62835[BUGFIX] disableNoCacheParameter option allows TypoScript cache option

Benni Mack CR +2 V +2 Easy +2 −2 updated 01/15/20, 11:04

Commit message

With this change applied, a TYPO3 installation having the
global "disableNoCacheParameter" option activated will
still disable the cache if set via TypoScript `config.no_cache = 1`.

However, the GET parameter is still not evaluated when
having the option activated.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Benni Mack uploaded patch set 1 01/09/20, 14:47

  2. TYPO3com voted on patch set 1 V -1 01/09/20, 14:57 Completed build in 10m 09s on Thu, 9 Jan, 02:57 PM Test Summary: 59115 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39768

  3. Georg Ringer voted on patch set 1 V +1 CR +1 01/09/20, 19:13

  4. TYPO3com commented on patch set 1 01/09/20, 20:39 Completed build in 6h 02m 43s on Thu, 9 Jan, 08:39 PM Test Summary: 12 of 69629 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39768

  5. TYPO3com voted on patch set 1 V +1 01/09/20, 21:07 Completed build in 12h 22m 45s on Thu, 9 Jan, 09:07 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39768

  6. Susi Moog voted on patch set 1 CR +1 01/14/20, 20:59

  7. Daniel Goerz voted on patch set 1 CR +1 01/14/20, 21:11

  8. Susi Moog uploaded patch set 2 01/14/20, 21:15

  9. Daniel Goerz voted on patch set 2 CR +1 01/14/20, 21:16

  10. Susi Moog voted on patch set 2 V +1 CR +1 01/14/20, 21:16

  11. TYPO3com voted on patch set 2 V +1 01/14/20, 21:40 Completed build in 16m 09s on Tue, 14 Jan, 09:40 PM Test Summary: 69524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39946

  12. Tobi Kretschmann voted on patch set 2 CR +1 01/15/20, 09:12

  13. Tobi Kretschmann voted on patch set 2 V +1 01/15/20, 09:28

  14. Tobi Kretschmann voted on patch set 2 V +2 CR +2 01/15/20, 09:30

  15. Tobi Kretschmann merged patch set 3 01/15/20, 09:30

  16. Claus Due commented on patch set 3 01/15/20, 11:04

    For posterity, please make sure that commit subjects can be expressed by prefacing: "When applied, this patch will..." In other words the subject shouldn't describe what *was* wrong, it should describe what *is* done to fix what was wrong.