Review main Merged

62836[BUGFIX] Properly set Reply-To address in mailer

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/09/20, 19:13

Commit message

The symfony/mailer instance needs an email address in the form
of new Address($emailAddress, $name);

The MailUtility::getSystemReplyTo() returns a strange (Swiftmailer-like)
syntax, which was implemented wrong when migrating to Symfony/Mailer.

The change switches the constructor arguments to be used in
the correct order ($email, $name).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 01/09/20, 15:41

  2. Mathias Brodala updated the commit message in patch set 2 01/09/20, 15:47

  3. Mathias Brodala voted on patch set 2 CR +1 01/09/20, 15:47

  4. TYPO3com voted on patch set 1 V +1 01/09/20, 15:51 Completed build in 09m 21s on Thu, 9 Jan, 03:51 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39769

  5. Markus Klein updated the commit message in patch set 3 01/09/20, 15:54

  6. Markus Klein voted on patch set 3 V +1 CR +1 01/09/20, 15:55

  7. Mathias Brodala voted on patch set 3 CR +1 01/09/20, 15:58

  8. TYPO3com voted on patch set 2 V +1 01/09/20, 15:59 Completed build in 12m 12s on Thu, 9 Jan, 03:59 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39770

  9. TYPO3com voted on patch set 3 V +1 01/09/20, 16:05 Completed build in 10m 21s on Thu, 9 Jan, 04:05 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39771

  10. Georg Ringer voted on patch set 3 V +2 CR +2 01/09/20, 19:13

  11. Georg Ringer merged patch set 4 01/09/20, 19:13