Review main Merged

62837[BUGFIX] Correctly display the CGI environment in Environment module

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/10/20, 09:00

Commit message

During the TYPO3 v9 install tool refactoring, a simple PHP array syntax
mistake did not correctly set the fluid variable "systemInformationCgiDetected"
which always resulted in not running in a CGI environment.

The change adapts the array variable assigment.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Michael Schams +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Michael Schams +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 01/10/20, 07:58

  2. Susi Moog voted on patch set 1 CR +1 01/10/20, 08:00

  3. Markus Klein voted on patch set 1 V +1 CR +1 01/10/20, 08:01

  4. TYPO3com voted on patch set 1 V -1 01/10/20, 08:06 Completed build in 08m 23s on Fri, 10 Jan, 08:06 AM Test Summary: 23 of 34752 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39776

  5. TYPO3com commented on patch set 1 01/10/20, 08:21 Completed build in 31m 10s on Fri, 10 Jan, 08:21 AM Test Summary: 67676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39776

  6. Michael Schams voted on patch set 1 V +1 CR +1 01/10/20, 08:22

  7. Oliver Klee voted on patch set 1 CR +1 01/10/20, 08:32

  8. TYPO3com voted on patch set 1 V +1 01/10/20, 08:51 Completed build in 1h 24m 33s on Fri, 10 Jan, 08:51 AM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39776

  9. Benni Mack voted on patch set 1 V +2 CR +2 01/10/20, 09:00

  10. Benni Mack merged patch set 2 01/10/20, 09:00