Review main Merged

62838[BUGFIX] Do not use the removed <i:constant> viewhelper anymore

Benni Mack CR +2 V +2 Easy +2 −1 updated 01/10/20, 15:41

Commit message

In the environment module, the removed <i:constant> viewhelper
is still referenced, which can easily be used by assigning
the proper variable to Fluid.

This change was merged last week due to the TYPO3_version
logic.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 01/10/20, 08:01

  2. Benni Mack updated the commit message in patch set 2 01/10/20, 08:03

  3. TYPO3com voted on patch set 2 V -1 01/10/20, 08:03 Completed build in 18s on Fri, 10 Jan, 08:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39778

  4. TYPO3com voted on patch set 1 V -1 01/10/20, 08:08 Completed build in 07m 00s on Fri, 10 Jan, 08:08 AM Test Summary: 9 of 24558 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39777

  5. Oliver Klee voted on patch set 2 CR +1 01/10/20, 08:33

  6. Benni Mack commented on patch set 2 01/10/20, 09:05

    Thx, Oli!
  7. TYPO3com voted on patch set 2 V +1 01/10/20, 09:40 Completed build in 1h 37m 51s on Fri, 10 Jan, 09:40 AM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39778

  8. Guido Schmechel voted on patch set 2 CR +1 01/10/20, 13:45

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/10/20, 14:05

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 01/10/20, 15:23

  11. Andreas Kienast merged patch set 3 01/10/20, 15:23

  12. Jonas Eberle commented on patch set 3 01/10/20, 15:41

    SystemInformation.html:1 Unresolved

    shouldn't the xmlns:i be removed as well?