Review main Merged

62841[BUGFIX] Fix OptimizeDatabaseTableTask for PDO and MySQLi

Manuel Selbach CR +2 V +2 Easy +1 −1 updated 01/10/20, 14:49

Commit message

With this change $connection::query() is used instead of
$connection::exec() which can not be used for statements
that return results, see:

https://www.php.net/manual/de/pdo.exec.php#61702

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Manuel Selbach uploaded patch set 1 01/10/20, 13:43

  2. Benni Mack voted on patch set 1 V +1 CR +1 01/10/20, 14:02

  3. TYPO3com voted on patch set 1 V -1 01/10/20, 14:15 Completed build in 18m 30s on Fri, 10 Jan, 02:15 PM Test Summary: 29 of 68420 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39789

  4. TYPO3com commented on patch set 1 01/10/20, 14:29 Completed build in 51m 26s on Fri, 10 Jan, 02:29 PM Test Summary: 29 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39789

  5. TYPO3com voted on patch set 1 V +1 01/10/20, 14:41 Completed build in 1h 35m 32s on Fri, 10 Jan, 02:41 PM Test Summary: 69191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39789

  6. Andreas Kienast commented on patch set 1 01/10/20, 14:48

    connection->exec() is also used in DataHandler for a SELECT query, may we change that as well?
  7. Andreas Kienast commented on patch set 1 V +2 CR +2 01/10/20, 14:49

    > Patch Set 1: > > connection->exec() is also used in DataHandler for a SELECT query, may we change that as well? Never mind, that's for pgsql...
  8. Andreas Kienast merged patch set 2 01/10/20, 14:49