Review main Abandoned

62842[BUGFIX] Provide EventDispatcher if no DI is available

Anja Leichsenring CR 0 V 0 Easy +20 −1 updated 01/14/20, 11:22

Commit message

Install Tool does not use Dependency Injection to its full extend,
this causes an exception if 'Remove temporary assets' action
is invoked.
Providing the object the old fashioned way for the time being
resolves the issue.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 46

  1. Anja Leichsenring uploaded patch set 1 01/10/20, 13:58

  2. Anja Leichsenring updated the commit message in patch set 2 01/10/20, 14:00

  3. TYPO3com voted on patch set 2 V -1 01/10/20, 14:07 Completed build in 01m 58s on Fri, 10 Jan, 02:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39792

  4. TYPO3com voted on patch set 1 V -1 01/10/20, 14:07 Completed build in 02m 03s on Fri, 10 Jan, 02:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39791

  5. Anja Leichsenring commented on patch set 2 01/10/20, 14:31

    decision needed first: integrate this as temporary fix or wait for https://review.typo3.org/c/Packages/TYPO3.CMS/+/62575
  6. Daniel Goerz abandoned the change 01/14/20, 11:22