62843[TASK] Move VerifyDenyPattern functionality into separate logic
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+10 −5
- typo3/sysext/core/Classes/Resource/Security/FileNameValidator.phpnew+86 −0
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+4 −3
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −5
- typo3/sysext/core/Configuration/DefaultConfiguration.php3+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-90147-UnifiedFileNameValidator.rstnew+60 −0
- typo3/sysext/core/Tests/Unit/Resource/Security/FileNameValidatorTest.php1new+255 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −131
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php+131 −0
- typo3/sysext/filelist/Classes/Controller/File/CreateFolderController.php+4 −2
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+2 −1
- typo3/sysext/impexp/Classes/Import.php+2 −1
- typo3/sysext/impexp/Classes/ImportExport.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstantMatcher.php+10 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/View/FolderUtilityRenderer.php+4 −2
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+7 −7
Review log 2232
Show 47 earlier messages
-
Benni Mack uploaded patch set 1 01/10/20, 14:24
-
Oliver Hader commented on patch set 1 01/10/20, 14:38
Should have some tests since it's security related... -
TYPO3com voted on patch set 1 V -1 01/10/20, 14:38 Completed build in 11m 33s on Fri, 10 Jan, 02:38 PM Test Summary: 1086 of 68763 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39795
-
Benni Mack uploaded patch set 2 01/14/20, 16:42
-
TYPO3com voted on patch set 2 V -1 01/14/20, 16:42 Completed build in 19s on Tue, 14 Jan, 04:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39922
-
Benni Mack updated the commit message in patch set 3 01/14/20, 16:50
-
TYPO3com voted on patch set 3 V +1 01/14/20, 17:04 Completed build in 11m 01s on Tue, 14 Jan, 05:04 PM Test Summary: 70193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39925
-
Benni Mack uploaded patch set 4 01/16/20, 10:51
-
TYPO3com voted on patch set 4 V +1 01/16/20, 12:09 Completed build in 25m 28s on Thu, 16 Jan, 12:09 PM Test Summary: 71054 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40029
-
Benni Mack uploaded patch set 5 01/18/20, 13:34
-
TYPO3com voted on patch set 5 V +1 01/18/20, 13:43 Completed build in 09m 37s on Sat, 18 Jan, 01:43 PM Test Summary: 71129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40068
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 01/18/20, 18:01
-
Anja Leichsenring rebased onto patch set 6 01/19/20, 09:09
-
Anja Leichsenring commented on patch set 6 V +1 CR +1 01/19/20, 09:09
sorry for the rebase, nothing changed. -
Oliver Hader voted on patch set 6 CR -1 01/19/20, 09:10
-
Oliver Hader voted on patch set 6 CR 0 01/19/20, 09:10
-
Oliver Hader commented on patch set 6 CR -1 01/19/20, 09:10
I'd like to have a closer look here... -
TYPO3com voted on patch set 6 V +1 01/19/20, 09:25 Completed build in 16m 12s on Sun, 19 Jan, 09:25 AM Test Summary: 71129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40077
-
Björn Jacob commented on patch set 6 01/19/20, 18:20
Unresolved
Is there missing something? IMHO yes. What could it be :) -
Benni Mack uploaded patch set 7 01/31/20, 07:51
-
TYPO3com voted on patch set 7 V +1 01/31/20, 08:01 Completed build in 10m 17s on Fri, 31 Jan, 08:01 AM Test Summary: 71527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40376
-
Andreas Kienast commented on patch set 7 CR -1 01/31/20, 10:12
DefaultConfiguration.php:1231Hm. This has the side-effect that this setting can't get changed anymore in the Install Tool. Shouldn't we null it by default? -
Benni Mack commented on patch set 7 01/31/20, 13:38
DefaultConfiguration.php:1231ReplyI see. Question for olly would be if we want this to be editable by the Settings -> All Configuration part. It's a regexp and should only be modified if you know what you're doing... -
Oliver Hader commented on patch set 7 03/10/20, 12:22
DefaultConfiguration.php:1231Reply UnresolvedFrom security point of view it does not really matter whether it can be modified in Install Tool or not... My gut feeling says "keep it in the Install Tool"...FileNameValidatorTest.php:240UnresolvedNot sure here... probably you'd like to test the functionality instead of testing the (low-level) pattern, correct? -
Benni Mack uploaded patch set 8 03/21/20, 19:43
-
TYPO3com voted on patch set 8 V -1 03/21/20, 19:54 Completed build in 10m 49s on Sat, 21 Mar, 07:54 PM Test Summary: 72626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1550
-
TYPO3com voted on patch set 8 V +1 03/22/20, 19:04 Completed build in 23h 31m 42s on Sun, 22 Mar, 07:04 PM Test Summary: 72918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1550
-
Oliver Hader uploaded patch set 9 03/23/20, 19:25
-
Oliver Hader voted on patch set 9 V +1 CR +1 03/23/20, 19:25
-
TYPO3com voted on patch set 9 V +1 03/23/20, 19:39 Completed build in 14m 02s on Mon, 23 Mar, 07:39 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1638
-
Georg Ringer voted on patch set 9 V +2 CR +2 03/23/20, 19:49
-
Georg Ringer merged patch set 10 03/23/20, 19:49