Review main Merged

62843[TASK] Move VerifyDenyPattern functionality into separate logic

Benni Mack CR +2 V +2 Hard +590 −160 updated 03/23/20, 19:49

Commit message

This change targets a couple of things:
- The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant
- The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed.
- The security aspect of checking against the fileDenyPattern is extracted into its own
Class where
- The fileDenyPattern can never be empty, but only be set via DefaultConfiguration.

This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 2232

Show 47 earlier messages
  1. Benni Mack uploaded patch set 1 01/10/20, 14:24

  2. Oliver Hader commented on patch set 1 01/10/20, 14:38

    Should have some tests since it's security related...
  3. TYPO3com voted on patch set 1 V -1 01/10/20, 14:38 Completed build in 11m 33s on Fri, 10 Jan, 02:38 PM Test Summary: 1086 of 68763 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39795

  4. Benni Mack uploaded patch set 2 01/14/20, 16:42

  5. TYPO3com voted on patch set 2 V -1 01/14/20, 16:42 Completed build in 19s on Tue, 14 Jan, 04:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39922

  6. Benni Mack updated the commit message in patch set 3 01/14/20, 16:50

  7. TYPO3com voted on patch set 3 V +1 01/14/20, 17:04 Completed build in 11m 01s on Tue, 14 Jan, 05:04 PM Test Summary: 70193 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39925

  1. Benni Mack uploaded patch set 4 01/16/20, 10:51

  2. TYPO3com voted on patch set 4 V +1 01/16/20, 12:09 Completed build in 25m 28s on Thu, 16 Jan, 12:09 PM Test Summary: 71054 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40029

  3. Benni Mack uploaded patch set 5 01/18/20, 13:34

  4. TYPO3com voted on patch set 5 V +1 01/18/20, 13:43 Completed build in 09m 37s on Sat, 18 Jan, 01:43 PM Test Summary: 71129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40068

  5. Anja Leichsenring voted on patch set 5 V +1 CR +1 01/18/20, 18:01

  6. Anja Leichsenring rebased onto patch set 6 01/19/20, 09:09

  7. Anja Leichsenring commented on patch set 6 V +1 CR +1 01/19/20, 09:09

    sorry for the rebase, nothing changed.
  8. Oliver Hader voted on patch set 6 CR -1 01/19/20, 09:10

  9. Oliver Hader voted on patch set 6 CR 0 01/19/20, 09:10

  10. Oliver Hader commented on patch set 6 CR -1 01/19/20, 09:10

    I'd like to have a closer look here...
  11. TYPO3com voted on patch set 6 V +1 01/19/20, 09:25 Completed build in 16m 12s on Sun, 19 Jan, 09:25 AM Test Summary: 71129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40077

  12. Björn Jacob commented on patch set 6 01/19/20, 18:20

    Unresolved

    Is there missing something? IMHO yes. What could it be :)
  13. Benni Mack uploaded patch set 7 01/31/20, 07:51

  14. TYPO3com voted on patch set 7 V +1 01/31/20, 08:01 Completed build in 10m 17s on Fri, 31 Jan, 08:01 AM Test Summary: 71527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40376

  15. Andreas Kienast commented on patch set 7 CR -1 01/31/20, 10:12

    DefaultConfiguration.php:1231

    Hm. This has the side-effect that this setting can't get changed anymore in the Install Tool. Shouldn't we null it by default?
  16. Benni Mack commented on patch set 7 01/31/20, 13:38

    DefaultConfiguration.php:1231 Reply

    I see. Question for olly would be if we want this to be editable by the Settings -> All Configuration part. It's a regexp and should only be modified if you know what you're doing...
  17. Oliver Hader commented on patch set 7 03/10/20, 12:22

    DefaultConfiguration.php:1231 Reply Unresolved

    From security point of view it does not really matter whether it can be modified in Install Tool or not... My gut feeling says "keep it in the Install Tool"...

    FileNameValidatorTest.php:240 Unresolved

    Not sure here... probably you'd like to test the functionality instead of testing the (low-level) pattern, correct?
  18. Benni Mack uploaded patch set 8 03/21/20, 19:43

  19. TYPO3com voted on patch set 8 V -1 03/21/20, 19:54 Completed build in 10m 49s on Sat, 21 Mar, 07:54 PM Test Summary: 72626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1550

  20. TYPO3com voted on patch set 8 V +1 03/22/20, 19:04 Completed build in 23h 31m 42s on Sun, 22 Mar, 07:04 PM Test Summary: 72918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1550

  21. Oliver Hader uploaded patch set 9 03/23/20, 19:25

  22. Oliver Hader voted on patch set 9 V +1 CR +1 03/23/20, 19:25

  23. TYPO3com voted on patch set 9 V +1 03/23/20, 19:39 Completed build in 14m 02s on Mon, 23 Mar, 07:39 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1638

  24. Georg Ringer voted on patch set 9 V +2 CR +2 03/23/20, 19:49

  25. Georg Ringer merged patch set 10 03/23/20, 19:49