Review main Merged

62844[TASK] Avoid superfluous Reflection invocation in tests

Oliver Hader CR +2 V +2 Easy +2 −17 updated 01/14/20, 10:25

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Tobi Kretschmann +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Tobi Kretschmann +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Oliver Hader uploaded patch set 1 01/10/20, 15:39

  2. TYPO3com voted on patch set 1 V -1 01/10/20, 15:40 Completed build in 14s on Fri, 10 Jan, 03:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39796

  3. Oliver Hader uploaded patch set 2 01/10/20, 15:41

  4. TYPO3com voted on patch set 2 V -1 01/10/20, 15:55 Completed build in 11m 36s on Fri, 10 Jan, 03:55 PM Test Summary: 68322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39797

  5. TYPO3com voted on patch set 2 V +1 01/10/20, 16:00 Completed build in 28m 27s on Fri, 10 Jan, 04:00 PM Test Summary: 69191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39797

  6. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 01/10/20, 21:36

  7. Alexander Schnitzler commented on patch set 2 01/11/20, 19:30

    ActionControllerTest.php:77 Unresolved

    FYI: Fine with this change. I introduced the tests this way to not have dependencies on the controller context, which I would like to get rid of soon.
  8. Tobi Kretschmann voted on patch set 2 CR +1 01/14/20, 09:57

  9. Tobi Kretschmann voted on patch set 2 V +1 01/14/20, 10:19

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 01/14/20, 10:25

  11. Daniel Goerz merged patch set 3 01/14/20, 10:25