Review main Merged

62853[TASK] Remove unused EditToolbarService

Susi Moog CR +2 V +2 Hard +0 −312 updated 01/12/20, 16:39

Commit message

As feedit has been removed from the core,
EditToolbarService is no longer in use.
As it was marked as internal it is removed
without further notice.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1

Issues 1

Files 2

Review log 1013

  1. Susi Moog uploaded patch set 1 01/12/20, 15:59

  2. Markus Klein updated the commit message in patch set 2 01/12/20, 16:06

  3. TYPO3com voted on patch set 1 V +1 01/12/20, 16:08 Completed build in 08m 41s on Sun, 12 Jan, 04:08 PM Test Summary: 69203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39826

  4. Markus Klein voted on patch set 2 V +1 CR +1 01/12/20, 16:08

  5. TYPO3com voted on patch set 2 V +1 01/12/20, 16:15 Completed build in 09m 10s on Sun, 12 Jan, 04:15 PM Test Summary: 69203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39828

  6. Daniel Goerz commented on patch set 2 01/12/20, 16:22

    EditToolbarService.php:72

    Can we remove all the labels too, then?
  7. Susi Moog uploaded patch set 3 01/12/20, 16:29

  8. Susi Moog commented on patch set 3 01/12/20, 16:29

    EditToolbarService.php:72 Reply Unresolved

    yes we can.
  9. Daniel Goerz voted on patch set 3 V +1 CR +1 01/12/20, 16:30

  10. Björn Jacob voted on patch set 3 V +1 CR +1 01/12/20, 16:30

  11. Daniel Goerz voted on patch set 3 V +2 CR +2 01/12/20, 16:37

  12. Daniel Goerz merged patch set 4 01/12/20, 16:37

  13. TYPO3com voted on patch set 3 V +1 01/12/20, 16:39 Completed build in 09m 45s on Sun, 12 Jan, 04:39 PM Test Summary: 69203 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39833