Review 9.5 Merged

62855[BUGFIX] Handle missing TSFE gracefully in TS conditions

Daniel Goerz CR +2 V +2 Easy +45 −2 updated 01/12/20, 18:26

Commit message

A condition like [getTSFE().id == 1] is evaluated in BE as well
and logged an error 'Unable to get a property on a non-object'.

This patch ensures that conditions based on getTSFE() are
treated gracefully and are evaluated to false.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 711

  1. Daniel Goerz uploaded patch set 1 01/12/20, 17:25

  2. Daniel Goerz uploaded patch set 2 01/12/20, 17:33

  3. TYPO3com voted on patch set 1 V -1 01/12/20, 17:34 Completed build in 08m 44s on Sun, 12 Jan, 05:33 PM Test Summary: 5 of 62980 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1787

  4. TYPO3com voted on patch set 2 V -1 01/12/20, 17:42 Completed build in 08m 59s on Sun, 12 Jan, 05:42 PM Test Summary: 6 of 72532 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1788

  5. Susi Moog uploaded patch set 3 01/12/20, 17:46

  6. Susi Moog uploaded patch set 4 01/12/20, 17:47

  7. TYPO3com voted on patch set 4 V -1 01/12/20, 17:57 Completed build in 09m 56s on Sun, 12 Jan, 05:57 PM Test Summary: 10 of 73286 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1790

  8. TYPO3com voted on patch set 4 V +1 01/12/20, 18:05 Completed build in 27m 45s on Sun, 12 Jan, 06:05 PM Test Summary: 72686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1790

  9. Susi Moog voted on patch set 4 V +1 CR +1 01/12/20, 18:18

  10. Daniel Goerz voted on patch set 4 V +2 CR +2 01/12/20, 18:26

  11. Daniel Goerz merged patch set 5 01/12/20, 18:26