Review main Merged

62856[BUGFIX] Preserve order of select items in FormEngine

Markus Klein CR +2 V +2 Easy +5 −2 updated 01/13/20, 11:06

Commit message

If a select field is comprised of static and dynamic
(database relation) values the order of items stored in
database is preserved when showing the select field.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Henning Liebe +1
    • Felix P. +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Henning Liebe +1
    • Felix P. +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Markus Klein uploaded patch set 1 01/12/20, 18:02

  2. TYPO3com voted on patch set 1 V -1 01/12/20, 18:10 Completed build in 07m 39s on Sun, 12 Jan, 06:10 PM Test Summary: 24 of 69656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39836

  3. Markus Klein uploaded patch set 2 01/12/20, 18:37

  4. Susi Moog commented on patch set 3 01/12/20, 18:44

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 01/12/20, 18:47 Completed build in 09m 13s on Sun, 12 Jan, 06:47 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39837

  6. TYPO3com voted on patch set 3 V +1 01/12/20, 18:55 Completed build in 10m 23s on Sun, 12 Jan, 06:55 PM Test Summary: 69204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39838

  7. Susi Moog voted on patch set 3 CR +1 01/12/20, 18:59

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 01/12/20, 21:04

  9. Felix P. voted on patch set 3 CR +1 01/13/20, 07:26

  10. Felix P. voted on patch set 3 V +1 01/13/20, 09:00

  11. Henning Liebe voted on patch set 3 V +1 CR +1 01/13/20, 10:05

  12. Sascha Rademacher voted on patch set 3 V +1 CR +1 01/13/20, 10:23

  13. Tobi Kretschmann voted on patch set 3 CR +1 01/13/20, 10:57

  14. Daniel Goerz voted on patch set 3 V +2 CR +2 01/13/20, 11:06

  15. Daniel Goerz merged patch set 4 01/13/20, 11:06