Review main Merged

62862[TASK] Remove custom InvalidArgumentException

Markus Klein CR +2 V +2 Easy +2 −25 updated 01/14/20, 14:05

Commit message

The name clash with the PHP native exception is not beneficial.
We replace it with \InvalidArgumentException.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Felix P. +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Felix P. +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1115

  1. Markus Klein uploaded patch set 1 01/13/20, 12:18

  2. TYPO3com voted on patch set 1 V -1 01/13/20, 12:26 Completed build in 07m 18s on Mon, 13 Jan, 12:26 PM Test Summary: 68933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39855

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 01/13/20, 12:35

  4. Benni Mack uploaded patch set 2 01/13/20, 12:39

  5. Benni Mack voted on patch set 2 V +1 CR +1 01/13/20, 12:39

  6. TYPO3com voted on patch set 1 V +1 01/13/20, 12:39 Completed build in 28m 00s on Mon, 13 Jan, 12:39 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39855

  7. Oliver Klee voted on patch set 2 CR +1 01/13/20, 12:40

  8. Felix P. voted on patch set 2 V +1 CR +1 01/13/20, 12:43

  9. TYPO3com voted on patch set 2 V -1 01/13/20, 12:48 Completed build in 09m 11s on Mon, 13 Jan, 12:48 PM Test Summary: 59138 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39856

  10. TYPO3com voted on patch set 2 V +1 01/13/20, 12:51 Completed build in 21m 38s on Mon, 13 Jan, 12:51 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39856

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 01/13/20, 12:52

  12. Andreas Kienast merged patch set 3 01/13/20, 12:52

  13. Mathias Brodala commented on patch set 3 01/13/20, 13:17

    Technically this is a breaking change and should be documented/postponed as such ...
  14. Benni Mack commented on patch set 3 01/14/20, 14:00

    > Patch Set 3: > > Technically this is a breaking change and should be documented/postponed as such ... good point. question for me is currently how/if we can make this "non-breaking". AFAIS we could remove the Exception completely.
  15. Mathias Brodala commented on patch set 3 01/14/20, 14:05

    > Patch Set 3: > > > Patch Set 3: > > > > Technically this is a breaking change and should be documented/postponed as such ... > > good point. question for me is currently how/if we can make this "non-breaking". AFAIS we could remove the Exception completely. That's true, but still we should document the removal.