Review main Merged

62864[BUGFIX] Ensure StaticRangeMapper applies zero prefix to internal map

Oliver Hader CR +2 V +2 Normal +200 −1 updated 01/14/20, 09:25

Commit message

StateRangeMapper routing aspects defined like the following did not use
leading zero (0) prefixes due to internal number conversion to integer:

    month:
      type: StaticRangeMapper
      start: '01'
      end: '12'

Zero prefixes are applied in case they were explicitly given in either
start or end property for StaticRangeMapper settings.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Markus Klein +1
    • Felix P. +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • Markus Klein +1
    • Felix P. +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Oliver Hader uploaded patch set 1 01/13/20, 15:17

  2. TYPO3com voted on patch set 1 V -1 01/13/20, 15:24 Completed build in 07m 37s on Mon, 13 Jan, 03:24 PM Test Summary: 48 of 69716 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39866

  3. Oliver Hader uploaded patch set 2 01/13/20, 16:10

  4. TYPO3com voted on patch set 2 V +1 01/13/20, 16:18 Completed build in 07m 47s on Mon, 13 Jan, 04:18 PM Test Summary: 69266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39867

  5. Susi Moog voted on patch set 2 V +1 CR +1 01/13/20, 17:56

  6. Markus Klein voted on patch set 2 V +1 CR +1 01/13/20, 18:54

  7. Tobi Kretschmann voted on patch set 2 CR +1 01/14/20, 07:55

  8. Felix P. voted on patch set 2 CR +1 01/14/20, 07:55

  9. Sascha Rademacher voted on patch set 2 V +1 CR +1 01/14/20, 08:15

  10. Steffen Frese voted on patch set 2 CR +1 01/14/20, 08:15

  11. Felix P. voted on patch set 2 V +1 01/14/20, 08:26

  12. Susi Moog voted on patch set 2 V +2 CR +2 01/14/20, 09:25

  13. Susi Moog merged patch set 3 01/14/20, 09:25