Review main Merged

62865[BUGFIX] Only include translated pages in sitemap

Daniel Goerz CR +2 V +2 Normal +122 −61 updated 01/19/20, 18:38

Commit message

When generating the list of pages for a sitemap in
an alternative language only pages are considered that
are actually translated or covered by the fallback
strategy.

Additionally the method generateItems() in the internal
class PagesXmlSitemapDataProvider is now protected.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Timo Poppinga +1
    • Susi Moog +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Timo Poppinga +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Daniel Goerz uploaded patch set 1 01/13/20, 17:17

  2. TYPO3com voted on patch set 1 V +1 01/13/20, 17:25 Completed build in 07m 33s on Mon, 13 Jan, 05:25 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39871

  3. Daniel Goerz uploaded patch set 2 01/13/20, 17:32

  4. Susi Moog voted on patch set 2 CR +1 01/13/20, 17:37

  5. TYPO3com voted on patch set 2 V +1 01/13/20, 17:43 Completed build in 09m 43s on Mon, 13 Jan, 05:43 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39873

  6. Susi Moog voted on patch set 2 V +1 01/13/20, 17:49

  7. Daniel Goerz commented on patch set 2 CR -1 01/13/20, 18:27

    Needs tests
  8. Daniel Goerz uploaded patch set 3 01/13/20, 18:44

  9. TYPO3com voted on patch set 3 V +1 01/13/20, 18:52 Completed build in 07m 56s on Mon, 13 Jan, 06:52 PM Test Summary: 69215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39878

  10. Susi Moog voted on patch set 3 CR +1 01/13/20, 19:25

  11. Susi Moog voted on patch set 3 V +1 01/13/20, 19:25

  12. Richard Haeser commented on patch set 3 V +2 CR +2 01/13/20, 21:05

    In my installation the patch has exactly the same output as before.
  13. Richard Haeser merged patch set 4 01/13/20, 21:05

  14. Timo Poppinga voted on patch set 4 V +1 CR +1 01/19/20, 18:38