Review main Merged

62869[TASK] Add page type enhancer tests for root page

Susi Moog CR +2 V +2 Normal +198 −35 updated 01/15/20, 20:22

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1829

Show 24 earlier messages
  1. Susi Moog uploaded patch set 1 01/13/20, 19:35

  2. TYPO3com voted on patch set 1 V +1 01/13/20, 19:42 Completed build in 07m 41s on Mon, 13 Jan, 07:42 PM Test Summary: 69206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39880

  3. Susi Moog uploaded patch set 2 01/13/20, 19:46

  4. TYPO3com voted on patch set 2 V -1 01/13/20, 19:53 Completed build in 06m 56s on Mon, 13 Jan, 07:53 PM Test Summary: 51 of 69656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39882

  1. Susi Moog uploaded patch set 3 01/13/20, 19:57

  2. TYPO3com voted on patch set 3 V -1 01/13/20, 20:05 Completed build in 07m 47s on Mon, 13 Jan, 08:05 PM Test Summary: 21 of 69656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39883

  3. Susi Moog uploaded patch set 4 01/14/20, 15:33

  4. TYPO3com voted on patch set 4 V -1 01/14/20, 15:33 Completed build in 18s on Tue, 14 Jan, 03:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39916

  5. Susi Moog uploaded patch set 5 01/14/20, 15:35

  6. TYPO3com voted on patch set 5 V -1 01/14/20, 15:48 Completed build in 12m 25s on Tue, 14 Jan, 03:48 PM Test Summary: 975 of 70837 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39917

  7. Susi Moog uploaded patch set 6 01/15/20, 13:16

  8. TYPO3com voted on patch set 6 V -1 01/15/20, 13:27 Completed build in 10m 35s on Wed, 15 Jan, 01:27 PM Test Summary: 3 of 70787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39969

  9. Susi Moog updated the commit message in patch set 7 01/15/20, 13:38

  10. Susi Moog rebased onto patch set 8 01/15/20, 13:59

  11. Susi Moog updated the commit message in patch set 9 01/15/20, 13:59

  12. Susi Moog commented on patch set 9 01/15/20, 13:59

    This change is ready for review.
  13. TYPO3com voted on patch set 7 V -1 01/15/20, 14:07 Completed build in 28m 50s on Wed, 15 Jan, 02:07 PM Test Summary: 2 of 69913 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39975

  14. TYPO3com voted on patch set 9 V -1 01/15/20, 14:21 Completed build in 19m 05s on Wed, 15 Jan, 02:21 PM Test Summary: 3 of 70787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39977

  15. TYPO3com voted on patch set 9 V +1 01/15/20, 14:38 Completed build in 55m 42s on Wed, 15 Jan, 02:38 PM Test Summary: 70337 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39977

  16. Daniel Goerz voted on patch set 9 V +1 CR +1 01/15/20, 15:33

  17. Daniel Goerz commented on patch set 9 01/15/20, 15:34

    EnhancerLinkGeneratorTest.php:232 Unresolved

    I guess this was only moved to a separate line for debugging purposes?
  18. Benni Mack voted on patch set 9 V +1 CR +1 01/15/20, 15:34

  19. Susi Moog updated the commit message in patch set 10 01/15/20, 15:43

  20. Daniel Goerz voted on patch set 10 V +1 CR +1 01/15/20, 15:43

  21. TYPO3com voted on patch set 10 V -1 01/15/20, 16:00 Completed build in 14m 09s on Wed, 15 Jan, 04:00 PM Test Summary: 6 of 70787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39987

  22. TYPO3com voted on patch set 10 V +1 01/15/20, 16:16 Completed build in 43m 26s on Wed, 15 Jan, 04:16 PM Test Summary: 70337 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39987

  23. Benni Mack voted on patch set 10 V +2 CR +2 01/15/20, 17:02

  24. Benni Mack merged patch set 11 01/15/20, 17:02

  25. Oliver Hader commented on patch set 11 01/15/20, 20:22

    What about back-porting to 9.5?