Review 9.5 Merged

62870[BUGFIX] Only include translated pages in sitemap

Daniel Goerz CR +2 V +2 Normal +119 −57 updated 01/14/20, 09:29

Commit message

When generating the list of pages for a sitemap in
an alternative language only pages are considered that
are actually translated or covered by the fallback
strategy.

Additionally the method generateItems() in the internal
class PagesXmlSitemapDataProvider is now protected.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Sascha Rademacher +1
    • Jörg Bösche +1
    • Felix P. +1
    • Susi Moog +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Sascha Rademacher +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Daniel Goerz uploaded patch set 1 01/13/20, 21:22

  2. TYPO3com voted on patch set 1 V -1 01/13/20, 21:32 Completed build in 09m 54s on Mon, 13 Jan, 09:32 PM Test Summary: 9 of 73301 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1803

  3. Daniel Goerz uploaded patch set 2 01/13/20, 21:51

  4. Daniel Goerz commented on patch set 2 01/13/20, 21:52

    Manual backport, please check
  5. Susi Moog voted on patch set 2 V +1 CR +1 01/13/20, 21:57

  6. TYPO3com voted on patch set 2 V +1 01/13/20, 22:01 Completed build in 09m 02s on Mon, 13 Jan, 10:00 PM Test Summary: 72695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1804

  7. Jörg Bösche voted on patch set 2 CR +1 01/14/20, 07:16

  8. Richard Haeser voted on patch set 2 V +2 CR +2 01/14/20, 08:42

  9. Richard Haeser merged patch set 3 01/14/20, 08:42

  10. Steffen Frese voted on patch set 2 CR +1 01/14/20, 08:42

  11. Felix P. voted on patch set 3 CR +1 01/14/20, 08:57

  12. Sascha Rademacher voted on patch set 3 V +1 CR +1 01/14/20, 09:29