Review main Merged

62872[BUGFIX] Fix search in file list mount points

Sebastian Hofer CR +2 V +2 Easy +1 −1 updated 01/17/20, 14:45

Commit message

In case of the first mount point of a storage in file list
\TYPO3\CMS\Core\Resource\ResourceStorage::getRootLevelFolder()
returns always the first mount point folder and not the real root
folder. This causes, that the condition is always true in case
of first mount point. If the condition is true, no folder restriction
is added. If no folder restriction is added the search is
done in the whole storage and not only in the selected folder.
With disrespecting the mount points this method always returns
the real root folder and the condition is only true if the selected
folder is the storage root folder. This means a folder restriction
is added in other cases.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Felix P. +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Sascha Rademacher +1
    • Felix P. +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Sebastian Hofer uploaded patch set 1 01/14/20, 07:30

  2. TYPO3com voted on patch set 1 V +1 01/14/20, 07:40 Completed build in 09m 10s on Tue, 14 Jan, 07:39 AM Test Summary: 69218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39886

  3. Tobi Kretschmann voted on patch set 1 V +1 CR +1 01/15/20, 11:32

  4. Sascha Rademacher voted on patch set 1 V +1 CR +1 01/15/20, 13:06

  5. Felix P. voted on patch set 1 V +1 CR +1 01/15/20, 13:43

  6. Steffen Frese voted on patch set 1 V +1 CR +1 01/16/20, 09:49

  7. Tobi Kretschmann voted on patch set 1 V +2 CR +2 01/17/20, 14:45

  8. Tobi Kretschmann merged patch set 2 01/17/20, 14:45