Review 9.5 Merged

62876[TASK] Refactor route enhancer tests

Susi Moog CR +2 V +2 Nightmare +2040 −821 updated 01/14/20, 15:03

Commit message

* replaces nested array logic with domain objects
* introduces perputation logic (instead of foreach/foreach/foreach/...)
* introduced common variables container compiled when executing tests
  (allows to declare arbitrary behaviour without hardcoding values)
* applies more specific page type decorators in request tests

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 56

  1. Susi Moog uploaded patch set 1 01/14/20, 11:09

  2. TYPO3com voted on patch set 1 V +1 01/14/20, 11:42 Completed build in 22m 45s on Tue, 14 Jan, 11:42 AM Test Summary: 73043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1816

  3. Susi Moog commented on patch set 1 01/14/20, 11:44

    This change is ready for review.
  4. Oliver Hader voted on patch set 1 CR +1 01/14/20, 12:20

  5. Oliver Hader voted on patch set 1 V +2 CR +2 01/14/20, 15:03

  6. Oliver Hader merged patch set 2 01/14/20, 15:03