Review main Merged

62880[TASK] Add test cases for handling of l18n_cfg field in pages sitemap

Daniel Goerz CR +2 V +2 Hard +239 −65 updated 01/14/20, 20:01

Commit message

The patch also adds tests for the behavior with
$GLOBALS['TYPO3_CONF_VARS']['FE']['hidePagesIfNotTranslatedByDefault']
enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 814

  1. Daniel Goerz uploaded patch set 1 01/14/20, 15:36

  2. Daniel Goerz uploaded patch set 2 01/14/20, 15:43

  3. TYPO3com voted on patch set 1 V +1 01/14/20, 15:48 Completed build in 11m 31s on Tue, 14 Jan, 03:48 PM Test Summary: 69584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39918

  4. TYPO3com voted on patch set 2 V +1 01/14/20, 15:51 Completed build in 08m 01s on Tue, 14 Jan, 03:51 PM Test Summary: 69587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39919

  5. Daniel Goerz updated the commit message in patch set 3 01/14/20, 15:56

  6. TYPO3com voted on patch set 3 V +1 01/14/20, 16:06 Completed build in 09m 46s on Tue, 14 Jan, 04:06 PM Test Summary: 69587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39920

  7. Benni Mack commented on patch set 3 V -1 01/14/20, 16:57

    The option is depending on $TYPO3_CONF_VARS[FE][hidePagesIfNotTranslatedByDefault], so we should take this into account or at least make this explicit in the tests.
  8. Daniel Goerz uploaded patch set 4 01/14/20, 18:16

  9. TYPO3com voted on patch set 4 V -1 01/14/20, 18:25 Completed build in 09m 19s on Tue, 14 Jan, 06:25 PM Test Summary: 58965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39930

  10. TYPO3com commented on patch set 4 01/14/20, 18:35 Completed build in 07m 26s on Tue, 14 Jan, 06:35 PM Test Summary: 69617 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39931

  11. TYPO3com voted on patch set 4 V +1 01/14/20, 18:44 Completed build in 08m 08s on Tue, 14 Jan, 06:44 PM Test Summary: 69626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39932

  12. Susi Moog voted on patch set 4 V +1 CR +1 01/14/20, 19:50

  13. Benni Mack voted on patch set 4 V +2 CR +2 01/14/20, 20:01

  14. Benni Mack merged patch set 5 01/14/20, 20:01