Review TYPO3_8-7 Merged

62881[BUGFIX] Cast indexer config to integers before multiplication

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 01/15/20, 10:19

Commit message

If either the options `minAge` or `maxAge` are an empty string, the
corresponding multiplication will fail and a PHP warning is triggered.

As a quick win, the values are casted to integers.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Rademacher +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Goerz uploaded patch set 1 01/14/20, 16:09

  2. Daniel Goerz commented on patch set 1 01/14/20, 16:09

    manual backport, please double check
  3. Daniel Goerz wrote 01/14/20, 16:09

    Assignee added: Andreas Fernandez <a.fernandez@scripting-base.de>
  4. TYPO3com voted on patch set 1 V +1 01/14/20, 16:20 Completed build in 09m 59s on Tue, 14 Jan, 04:20 PM Test Summary: 101771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3834

  5. Andreas Kienast voted on patch set 1 CR +1 01/15/20, 07:53

  6. Sascha Rademacher voted on patch set 1 CR +1 01/15/20, 08:58

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 01/15/20, 10:18

  8. Daniel Goerz merged patch set 2 01/15/20, 10:19