Review main Merged

62889[BUGFIX] Do not escape nested tags in parseFunc

Benni Mack CR +2 V +2 Easy +42 −1 updated 01/15/20, 11:56

Commit message

Due to the rector refactoring a line unset($currentTag) was removed,
resulting in text-elements with <p>something <a href="...">links</a>.</p>
did not detect a proper closing tag, resulting in broken HTML
in the output.

Additional tests properly check for this logic now.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 46

  1. Benni Mack uploaded patch set 1 01/15/20, 10:32

  2. TYPO3com voted on patch set 1 V -1 01/15/20, 10:40 Completed build in 08m 20s on Wed, 15 Jan, 10:40 AM Test Summary: 69242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39960

  3. TYPO3com voted on patch set 1 V +1 01/15/20, 11:30 Completed build in 1h 05m 45s on Wed, 15 Jan, 11:30 AM Test Summary: 69527 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39960

  4. Susi Moog voted on patch set 1 V +1 CR +1 01/15/20, 11:37

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 01/15/20, 11:56

  6. Daniel Goerz merged patch set 2 01/15/20, 11:56