Review 9.5 Merged

62893[BUGFIX] Ensure StaticRangeMapper applies zero prefix to internal map

Susi Moog CR +2 V +2 Normal +200 −1 updated 01/14/20, 10:02

Commit message

StateRangeMapper routing aspects defined like the following did not use
leading zero (0) prefixes due to internal number conversion to integer:

    month:
      type: StaticRangeMapper
      start: '01'
      end: '12'

Zero prefixes are applied in case they were explicitly given in either
start or end property for StaticRangeMapper settings.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Susi Moog commented on patch set 1 01/14/20, 09:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 01/14/20, 09:34 Completed build in 08m 57s on Tue, 14 Jan, 09:34 AM Test Summary: 72754 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1806

  3. TYPO3com voted on patch set 1 V +1 01/14/20, 09:54 Completed build in 37m 58s on Tue, 14 Jan, 09:54 AM Test Summary: 72755 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1806

  4. Oliver Hader voted on patch set 1 V +2 CR +2 01/14/20, 10:01

  5. Oliver Hader merged patch set 2 01/14/20, 10:02