Review 9.5 Merged

62894[BUGFIX] Show argument validation results in scheduler list

Daniel Goerz CR +2 V +2 Easy +13 −2 updated 01/14/20, 10:45

Commit message

The scheduler module now shows validation errors for execute console
commands as messages in the backend. Previously changing the
configuration of a console commands arguments could lead to an exception
when the currently selected set of arguments was not parseable anymore
with the new configuration.
In some circumstances it was also possible to save a task without
supplying all required arguments, which rendered the backend module
non-functional because of the exception.

Catching the exception and providing the error message helps spotting
and fixing these errors without having to manipulate the database
directly.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Daniel Goerz commented on patch set 1 01/14/20, 10:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/14/20, 10:34 Completed build in 11m 42s on Tue, 14 Jan, 10:34 AM Test Summary: 72755 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1807

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 01/14/20, 10:44

  4. Daniel Goerz merged patch set 2 01/14/20, 10:45