Review 9.5 Merged

62899[BUGFIX] Respect fallback languages in slug generation for pages

Benni Mack CR +2 V +2 Normal +240 −4 updated 01/16/20, 15:17

Commit message

When creating a new subpage of another page, the TCA type "slug" will
automatically generate a slug for the new page which uses the title
of the parent page. When translating the page, the slug will try to get
the correct language for the parent record (if possible). This check did
previously not respect possible fallback languages for the language of
the new record. (configured in the site configuration)

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
  • Verified V +2 Done
    • Susi Moog +2
    • Sascha Rademacher +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 58

  1. Benni Mack commented on patch set 1 01/14/20, 14:03

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 01/14/20, 14:13 Completed build in 09m 18s on Tue, 14 Jan, 02:13 PM Test Summary: 1467 of 73290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1820

  3. TYPO3com commented on patch set 1 01/14/20, 14:28 Completed build in 33m 21s on Tue, 14 Jan, 02:28 PM Test Summary: 1467 of 73290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1820

  4. Benni Mack uploaded patch set 2 01/14/20, 14:39

  5. TYPO3com voted on patch set 2 V +1 01/14/20, 14:50 Completed build in 10m 46s on Tue, 14 Jan, 02:50 PM Test Summary: 72767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1821

  6. Sascha Rademacher voted on patch set 2 V +1 CR +1 01/16/20, 13:58

  7. Susi Moog voted on patch set 2 V +2 CR +2 01/16/20, 15:17

  8. Susi Moog merged patch set 3 01/16/20, 15:17