Review 9.5 Merged

62901[BUGFIX] Cast indexer config to integers before multiplication

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 01/14/20, 16:51

Commit message

If either the options `minAge` or `maxAge` are an empty string, the
corresponding multiplication will fail and a PHP warning is triggered.

As a quick win, the values are casted to integers.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 01/14/20, 16:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/14/20, 16:17 Completed build in 15m 21s on Tue, 14 Jan, 04:17 PM Test Summary: 73043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1823

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 01/14/20, 16:51

  4. Daniel Goerz merged patch set 2 01/14/20, 16:51